Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL typo in PCMQ4Mv2 dataset #8222

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

pbielak
Copy link
Contributor

@pbielak pbielak commented Oct 19, 2023

In the download() method is a typo: self.url_2d should be named self.url

@pbielak pbielak requested a review from wsad1 as a code owner October 19, 2023 11:28
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #8222 (27604df) into master (71a7fee) will decrease coverage by 0.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8222      +/-   ##
==========================================
- Coverage   88.08%   87.39%   -0.69%     
==========================================
  Files         473      473              
  Lines       28605    28601       -4     
==========================================
- Hits        25197    24997     -200     
- Misses       3408     3604     +196     

see 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@EdisonLeeeee EdisonLeeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@EdisonLeeeee EdisonLeeeee changed the title Fix URL attribute name in PCMQ4Mv2 dataset Fix URL typo in PCMQ4Mv2 dataset Oct 19, 2023
@EdisonLeeeee EdisonLeeeee merged commit 62a2d63 into pyg-team:master Oct 19, 2023
@pbielak pbielak deleted the fix-field-name-in-pcqmc4m branch October 19, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants