Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HeteroConv for layers that have a non-default argument order #8166

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Fix HeteroConv for layers that have a non-default argument order #8166

merged 6 commits into from
Oct 9, 2023

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Oct 9, 2023 •
edited
Loading

Fixes #8150

@rusty1s rusty1s self-assigned this Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #8166 (21f4fd2) into master (849a1cb) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #8166      +/-   ##
==========================================
- Coverage   87.41%   87.40%   -0.01%     
==========================================
  Files         473      473              
  Lines       28580    28586       +6     
==========================================
+ Hits        24982    24985       +3     
- Misses       3598     3601       +3
Files Coverage Δ
torch_geometric/nn/conv/utils/cheatsheet.py 100.00% <100.00%> (ø)
torch_geometric/explain/algorithm/utils.py 94.11% <83.33%> (-2.66%) ⬇️
torch_geometric/nn/conv/hetero_conv.py 95.71% <84.61%> (-2.84%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusty1s rusty1s merged commit 4d280f5 into master Oct 9, 2023
@rusty1s rusty1s deleted the fix_hetero_conv branch October 9, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsad1 wsad1 Awaiting requested review from wsad1 wsad1 is a code owner

@EdisonLeeeee EdisonLeeeee Awaiting requested review from EdisonLeeeee EdisonLeeeee is a code owner

@RexYing RexYing Awaiting requested review from RexYing RexYing is a code owner

@RBendias RBendias Awaiting requested review from RBendias RBendias is a code owner

@dufourc1 dufourc1 Awaiting requested review from dufourc1 dufourc1 is a code owner

Assignees

@rusty1s rusty1s

Labels
0 - Priority P0 bug explain nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rusty1s