-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GMNConv
and an example on ZINC
#6775
base: master
Are you sure you want to change the base?
Conversation
GMNConv
and an example on ZINC
Codecov Report
@@ Coverage Diff @@
## master #6775 +/- ##
==========================================
+ Coverage 87.40% 87.42% +0.01%
==========================================
Files 473 474 +1
Lines 28570 28631 +61
==========================================
+ Hits 24972 25030 +58
- Misses 3598 3601 +3
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you find the implementation fully functional for PyG!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changes for GMNConv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the implementation, I'll read the paper linked to make sure I'm aligned, you'll probably just need to add some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the delay and thanks again for the implementation ! Here are a few notes on the code and some more general comments.
Parts of the method are similar to PNA (PNAConv
). I wonder if there is a way of reusing the code already available ? What do you think ?
For the tests you might want to check what is done here https://github.com/pyg-team/pytorch_geometric/blob/master/test/nn/conv/test_pna_conv.py.
Hi! Thanks for the feedback! I rearranged the code that you mentioned in the comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, thanks a lot for the requested changes 👍🏽
I have added a few comments, but maybe it's only because I am confused with the similarity with PNAConv
.
Hello @dufourc1, Thank you for your insights on the code. I have made updates in the sections you highlighted and added comments where you've provided feedback.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ! The main points look good to me. Once you've updated your code to pass the CI tests,
this should be all good.
Thank you so much!
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hi @dufourc1, The code has successfully passed the CI checks! Thank you once again for your feedback🙌. |
Adding The Graph Mixer Networks (https://arxiv.org/abs/2301.12493) Conv operator and example on ZINC