add a doc page on models #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weihua916
approved these changes
Oct 12, 2023
|
Thanks! Maybe somewhere we need to clarify that models take |
weihua916
reviewed
Oct 13, 2023
| @@ -81,7 +81,7 @@ def forward(self, tf: TensorFrame) -> Tensor: | |||
| x (Tensor): Input :obj:`TensorFrame` object. | |||
|
|
|||
| Returns: | |||
| out (Tensor): Output. The shape is [batch_size, out_channels]. | |||
| Tensor: Output. The shape is [batch_size, out_channels]. | |||
There was a problem hiding this comment.
If we were to do this, then we should do this across all the places.
There was a problem hiding this comment.
Ohh I am just experimenting the syntax.
The return arguments look really weird in the documentation.
I think changing the syntax to above would resolve. I am going to do that for everything.
added 15 commits
October 13, 2023 19:08
added 5 commits
October 15, 2023 20:44
…/pytorch-frame into yyuan/add-modular-documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.