Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce optional dependencies #108

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Introduce optional dependencies #108

merged 3 commits into from
Oct 12, 2023

Conversation

akihironitta
Copy link
Member

This is a follow-up PR of #103.

The mandatory dependencies will now be:

numpy
pandas
torch

@akihironitta akihironitta self-assigned this Oct 12, 2023
@weihua916 weihua916 requested a review from rusty1s October 12, 2023 08:06
rusty1s
rusty1s approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, I was just about to send the same PR :D

@rusty1s rusty1s merged commit 2379fd7 into master Oct 12, 2023
@rusty1s rusty1s deleted the aki-deps branch October 12, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

Assignees

@akihironitta akihironitta

Labels
installation skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akihironitta @rusty1s