Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MKL codepath in replace=False sampling #275

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

rusty1s
Copy link
Member

@rusty1s rusty1s commented Nov 9, 2023

No description provided.

@rusty1s rusty1s changed the title Remove MKL codepath in replace=False sampling code path Remove MKL codepath in replace=False sampling Nov 9, 2023
@rusty1s
Copy link
Member Author

rusty1s commented Nov 9, 2023

Introduced by #222.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #275 (7daf197) into master (1fda0d7) will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   85.24%   85.74%   +0.49%     
==========================================
  Files          32       32              
  Lines        1098     1087      -11     
==========================================
- Hits          936      932       -4     
+ Misses        162      155       -7     
Files Coverage Δ
pyg_lib/csrc/sampler/cpu/neighbor_kernel.cpp 88.58% <ø> (+2.94%) ⬆️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rusty1s rusty1s merged commit 664acb4 into master Nov 9, 2023
10 checks passed
@rusty1s rusty1s deleted the fix_sampling branch November 9, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant