Add macOS M1 support (#310)

pyg-team · Mar 20, 2024 · 0584ce5 · 0584ce5
1 parent 0228406
commit 0584ce5
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 14 deletions.
diff --git a/.github/workflows/building.yml b/.github/workflows/building.yml
@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-20.04, macos-11, windows-2019]
+        os: [ubuntu-20.04, macos-14, windows-2019]
         python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
         torch-version: [1.12.0, 1.13.0, 2.0.0, 2.1.0, 2.2.0]
         cuda-version: ['cpu', 'cu113', 'cu116', 'cu117', 'cu118', 'cu121']
@@ -58,23 +58,20 @@ jobs:
             cuda-version: 'cu116'
           - torch-version: 2.2.0
             cuda-version: 'cu117'
-          - os: macos-11
+          - os: macos-14
             cuda-version: 'cu113'
-          - os: macos-11
+          - os: macos-14
             cuda-version: 'cu116'
-          - os: macos-11
+          - os: macos-14
             cuda-version: 'cu117'
-          - os: macos-11
+          - os: macos-14
             cuda-version: 'cu118'
-          - os: macos-11
+          - os: macos-14
             cuda-version: 'cu121'
-            # Fails with:
-            # * note: 'value' has been explicitly marked unavailable here
-            # * error: 'value' is unavailable: introduced in macOS 10.13
-          - os: macos-11
-            python-version: '3.11'
-          - os: macos-11
-            python-version: '3.12'
+          - os: macos-14
+            python-version: '3.8'
+          - os: macos-14
+            python-version: '3.9'
 
     steps:
       - name: Checkout repository

diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -14,11 +14,12 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-20.04]
+        os: [ubuntu-20.04, macos-14, windows-2019]
         python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
         torch-version: [1.12.0, 1.13.0, 2.0.0, 2.1.0, 2.2.0]
         cuda-version: ['cpu', 'cu113', 'cu116', 'cu117', 'cu118', 'cu121']
         exclude:
+          - os: windows-2019  # No windows support yet :(
           - torch-version: 1.12.0
             python-version: '3.12'
           - torch-version: 1.13.0
@@ -61,6 +62,20 @@ jobs:
             cuda-version: 'cu116'
           - torch-version: 2.2.0
             cuda-version: 'cu117'
+          - os: macos-14
+            cuda-version: 'cu113'
+          - os: macos-14
+            cuda-version: 'cu116'
+          - os: macos-14
+            cuda-version: 'cu117'
+          - os: macos-14
+            cuda-version: 'cu118'
+          - os: macos-14
+            cuda-version: 'cu121'
+          - os: macos-14
+            python-version: '3.8'
+          - os: macos-14
+            python-version: '3.9'
 
     steps:
       - name: Checkout repository

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 ## [0.5.0] - 2023-MM-DD
 ### Added
+- Added macOS Apple Silicon support ([#310](https://github.com/pyg-team/pyg-lib/pull/310))
 ### Changed
 ### Removed