Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply new cookiecutter #79

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Apply new cookiecutter #79

wants to merge 11 commits into from

Conversation

ahms5
Copy link
Member

@ahms5 ahms5 commented Dec 12, 2024 •
edited
Loading

todos:

  • fix example: spharpy.plot.contour_map(coords, data)
  • fix deprecation warnings

@ahms5 ahms5 mentioned this pull request Dec 12, 2024
Closed
@ahms5 ahms5 added the v1.0.0 label Dec 12, 2024
@mberz mberz added this to the v1.0.0 milestone Jan 3, 2025
@mberz
Copy link
Member

mberz commented Jan 7, 2025 •
edited
Loading

I may have made a bit of a mess when cleaning up the current state of the develop branch, introducing a few conflicts 💩

@ahms5 ahms5 requested a review from mberz January 7, 2025 14:06
@mberz
Copy link
Member

mberz commented Jan 7, 2025

There's a separate PR for adapting to the new set of ruff rules #90
Sorry, I've had this on a branch that had no active PR assigned yet. Let's maybe keep this separate. If you want you can take over the other PR.

mberz
mberz requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@mberz mberz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things wasn't sure about and a couple of things which have been deleted prematurely I guess ;)

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
docs/Makefile Show resolved Hide resolved
docs/make.bat Outdated Show resolved Hide resolved
examples/general_beamforming_weights.ipynb Outdated Show resolved Hide resolved
examples/plane_wave_decomposition.ipynb Outdated Show resolved Hide resolved
examples/spherical_harmonics.ipynb Outdated Show resolved Hide resolved
@ahms5
Copy link
Member Author

ahms5 commented Jan 8, 2025

@mberz all comments adresse, but no idea how to revert this change of the docs/make.bat

@ahms5 ahms5 requested a review from mberz January 8, 2025 12:01
@ahms5 ahms5 mentioned this pull request Jan 8, 2025
Merged
@mberz
Copy link
Member

mberz commented Jan 10, 2025

The issue with the contour plot seems to be caused by a change in the behavior of the interpolation of the data to a uniform grid.
Either within the triangulation or the interpolation based on the triangulation.

@mberz mberz mentioned this pull request Jan 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberz mberz mberz approved these changes

Assignees
No one assigned
Labels
v1.0.0
Projects
Weekly Planning
Status: Reviewer Approved
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ahms5 @mberz