-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose some DTLS-related features #1026
Conversation
71811ba
to
ce44736
Compare
For now I'm just skipping the new DTLS test when running against older |
Would you mind shifting the CI changes to a separate PR? We can merge those immediately. Also, is it a hard requirement that we raise our version minimum or can we feature detect here in a sane fashion? (It's okay if the answer to that is no) Also looks like we have a variety of missing lines of coverage, although that may just be codecov being stupid, I haven't looked. |
Depends on what kind of feature detection you want. Having |
Also AFAICT all the missed coverage lines are to handle obscure things that can allegedly happen with libressl/old openssl/etc., so the issue is that pyopenssl doesn't test against these in CI. Do we care? I think the worst case is that people using exotic openssl-like libraries might get the wrong exception. |
b7119f5
to
02b4b6c
Compare
The unrelated CI fixes/py 2 dropping/etc. have now all been merged, and I rebased this on top of them. So now this PR is just the DTLS changes, and I guess r4r. |
5f71619
to
4428c9b
Compare
4428c9b
to
7f8b052
Compare
0c6a19c
to
51f6743
Compare
black is angry |
yeah, PR currently contains a bunch of temporary nonsense to try to debug
the bionic hangs. I'll clean it up once I figure out a solution.
…On Sat, Oct 30, 2021 at 10:32 PM Paul Kehrer ***@***.***> wrote:
black is angry
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1026 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEU42D73ZAAX4ZHDU6ODT3UJTIFNANCNFSM47LE23RA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Nathaniel J. Smith -- https://vorpus.org <http://vorpus.org>
|
505afd2
to
a601c73
Compare
d9aca09
to
85ad2a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit more missing coverage than I'd prefer, but most of that is fixable if we add a 1.1.0 builder to our CI...which I am not volunteering for.
This is enough to make it at least possible to set up a DTLS association and exchange encrypted data, though a high quality implementation still requires a ton of scaffolding code (see python-trio/trio#2010).
Depends on pyca/cryptography#6138