Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Tooltips are always shown in light mode, even in dark mode. #2348

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Jan 3, 2025

I know some people that would argue that's a health issue (me).

  • Closes Dark mode for hoverxref tooltips #2346
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • [ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.
  • Links to the relevant documentation pages cause you think about the other maintainers: https://pvlib-python--2348.org.readthedocs.build/en/2348/

@echedey-ls echedey-ls added this to the v0.11.3 milestone Jan 3, 2025
@RDaxini
Copy link
Contributor

RDaxini commented Jan 3, 2025

funny branch name 😂

@wholmgren
Copy link
Member

Have we considered fixing this upstream instead of in pvlib?

@echedey-ls
Copy link
Contributor Author

Have we considered fixing this upstream instead of in pvlib?

That would be nuts, although it does not seem easy since each theme (e.g. pydata-sphinx-theme) provides it's own way of specifying the theme colours (source comment). Anyways, they would surely welcome any PR in that regard. I wouldn't be able to do so, thou. So I propose mitigating this problem now this easy way and removing these changes in the future once it gets fixed (if so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode for hoverxref tooltips
3 participants