Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update irradiance component definitions in nomenclature.rst #2289

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

RDaxini
Copy link
Contributor

@RDaxini RDaxini commented Nov 5, 2024

Work in progress. Not for review.

  • Partially addresses Glossary page updates tracking #2284; related comment
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini mentioned this pull request Nov 18, 2024
7 tasks
@RDaxini RDaxini marked this pull request as ready for review November 21, 2024 17:22
@RDaxini RDaxini changed the title [WIP] Update poa irradiance component definitions Update irradiance component definitions Nov 21, 2024
@kandersolar kandersolar added this to the v0.11.2 milestone Nov 25, 2024
@RDaxini
Copy link
Contributor Author

RDaxini commented Nov 25, 2024

do we need a whatsnew entry? I guess not?

@kandersolar kandersolar changed the title Update irradiance component definitions Update irradiance component definitions in nomenclature.rst Dec 3, 2024
@kandersolar kandersolar merged commit cbd72f5 into pvlib:main Dec 3, 2024
21 checks passed
@RDaxini RDaxini deleted the glossary-irradiance-wording branch December 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants