pvlib · echedey-ls · Oct 22, 2024 · Oct 22, 2024 · Oct 22, 2024 · Oct 22, 2024
diff --git a/.github/workflows/pytest-remote-data.yml b/.github/workflows/pytest-remote-data.yml
@@ -100,7 +100,7 @@ jobs:
           SOLARANYWHERE_API_KEY: ${{ secrets.SOLARANYWHERE_API_KEY }}
           BSRN_FTP_USERNAME: ${{ secrets.BSRN_FTP_USERNAME }}
           BSRN_FTP_PASSWORD: ${{ secrets.BSRN_FTP_PASSWORD }}
-        run: pytest pvlib/tests/iotools --cov=./ --cov-report=xml --remote-data
+        run: pytest tests/iotools --cov=./ --cov-report=xml --remote-data
 
       - name: Upload coverage to Codecov
         if: matrix.python-version == 3.9 && matrix.suffix == ''

diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
@@ -79,7 +79,7 @@ jobs:
         shell: bash -l {0}  # necessary for conda env to be active
         run: |
           # ignore iotools; those tests are run in a separate workflow
-          pytest pvlib --cov=./ --cov-report=xml --ignore=pvlib/tests/iotools
+          pytest tests --cov=./ --cov-report=xml --ignore=tests/iotools
 
       - name: Upload coverage to Codecov
         if: matrix.python-version == 3.9 && matrix.suffix == '' && matrix.os == 'ubuntu-latest' && matrix.environment-type == 'conda'

diff --git a/.gitignore b/.gitignore
@@ -81,9 +81,9 @@ coverage.xml
 
 
 # Datafiles
-*.csv
-# Ignore some csv 
-!pvlib/data/*.csv 
+# Do not exclude data directories
+!pvlib/data/**
+!tests/data/**
 
 # vi
 *.swp

diff --git a/codecov.yml b/codecov.yml
@@ -14,14 +14,15 @@ flags:
   core:
     paths:
       - pvlib/
+      - tests/
       - '!pvlib/iotools/'
-      - '!pvlib/tests/iotools/'
+      - '!tests/iotools/'
     carryforward: false
 
   remote-data:
     paths:
       - pvlib/iotools/
-      - pvlib/tests/iotools
+      - tests/iotools
     carryforward: true  # if not run, use coverage from previous commit
 
 
@@ -47,15 +48,15 @@ coverage:
       tests-core:
         target: 95%
         paths:
-          - 'pvlib/tests/.*'
-          - '!pvlib/tests/iotools/.*'
+          - 'tests/.*'
+          - '!tests/iotools/.*'
         flags:
           - core
 
       tests-remote-data:
         target: 95%
         paths:
-          - 'pvlib/tests/iotools/.*'
+          - 'tests/iotools/.*'
         flags:
           - remote-data
 

diff --git a/docs/sphinx/source/contributing/testing.rst b/docs/sphinx/source/contributing/testing.rst
@@ -11,7 +11,7 @@ Overview
 Developers **must** include comprehensive tests for any additions or
 modifications to pvlib. New unit test code should be placed in the
 corresponding test module in the
-`pvlib/tests <https://github.com/pvlib/pvlib-python/tree/main/pvlib/tests>`_
+`tests <https://github.com/pvlib/pvlib-python/tree/main/tests>`_
 directory.
 
 A pull request will automatically run the tests for you on a variety of
@@ -30,11 +30,11 @@ pvlib directory::
 
 or, for a single module::
 
-    pytest pvlib/tests/test_clearsky.py
+    pytest tests/test_clearsky.py
 
 or, for a single test::
 
-    pytest pvlib/tests/test_clearsky.py::test_ineichen_nans
+    pytest tests/test_clearsky.py::test_ineichen_nans
 
 We suggest using pytest's ``--pdb`` flag to debug test failures rather
 than using ``print`` or ``logging`` calls. For example::

diff --git a/docs/sphinx/source/whatsnew/v0.11.2.rst b/docs/sphinx/source/whatsnew/v0.11.2.rst
@@ -12,6 +12,10 @@ Deprecations
 
 Enhancements
 ~~~~~~~~~~~~
+* Reduced space requirements by excluding tests and test files from wheel.
+  Zipped wheel is now 66% of the previous size, and installed size is 50% of
+  the previous size.
+  (:issue:`2271`, :pull:`2277`)
 * Add :py:func:`~pvlib.atmosphere.rh_from_tdew` and :py:func:`~pvlib.atmosphere.tdew_from_rh`.
   (:issue:`1744`, :pull:`2286`)
 * :py:func:`~pvlib.ivtools.sdm.fit_desoto` now allows input of initial
@@ -63,6 +67,12 @@ Documentation
 
 Testing
 ~~~~~~~
+* Moved tests folder to `/tests` and data exclusively used for testing to `/tests/data`.
+  (:issue:`2271`, :pull:`2277`)
+
+Requirements
+~~~~~~~~~~~~
+
 * Update test files to track new PVGIS 5.3 data. (:pull:`2305`)
 
 Maintenance

diff --git a/docs/sphinx/source/whatsnew/v0.7.2.rst b/docs/sphinx/source/whatsnew/v0.7.2.rst
@@ -46,7 +46,7 @@ Bug fixes
 * Fix :py:func:`~pvlib.iotools.read_tmy3` parsing when February contains
   a leap year. (:pull:`866`)
 * Implement NREL Developer Network API key for consistent success with API
-  calls in :py:mod:`pvlib.tests.iotools.test_psm3`. (:pull:`873`)
+  calls in `pvlib.tests.iotools.test_psm3`. (:pull:`873`)
 * Fix issue with :py:class:`pvlib.location.Location` creation when
   passing ``tz=datetime.timezone.utc``. (:pull:`879`)
 * Fix documentation homepage title to "pvlib python" based on first heading on

diff --git a/pyproject.toml b/pyproject.toml
@@ -85,14 +85,22 @@ all = ["pvlib[test,optional,doc]"]
 Documentation = "https://pvlib-python.readthedocs.io/"
 "Source Code" = "https://github.com/pvlib/pvlib-python"
 
+[tool.setuptools]
+# do not include all non-python files in the bdist by default, but select them manually
+# https://setuptools.pypa.io/en/latest/userguide/datafiles.html#interplay-between-these-keywords (2024-10-22)
+include-package-data = false  # true by default
+
 [tool.setuptools.packages.find]
 include = ["pvlib*"]
 
+[tool.setuptools.package-data]
+pvlib = ["data/*"]
+
 [tool.setuptools_scm]
 
 [tool.pytest]
 junit_family = "xunit2"
-testpaths = "pvlib/tests"
+testpaths = "tests"
 # warning messages to suppress from pytest output.  useful in cases
 # where a dependency hasn't addressed a deprecation yet, and there's
 # nothing we can do to fix it ourselves.

diff --git a/pvlib/tests/__init__.py → tests/__init__.py b/pvlib/tests/__init__.py → tests/__init__.py
diff --git a/pvlib/tests/bifacial/__init__.py → tests/bifacial/__init__.py b/pvlib/tests/bifacial/__init__.py → tests/bifacial/__init__.py
diff --git a/pvlib/tests/bifacial/test_infinite_sheds.py → tests/bifacial/test_infinite_sheds.py b/pvlib/tests/bifacial/test_infinite_sheds.py → tests/bifacial/test_infinite_sheds.py
@@ -5,7 +5,7 @@
 import numpy as np
 import pandas as pd
 from pvlib.bifacial import infinite_sheds
-from ..conftest import assert_series_equal
+from tests.conftest import assert_series_equal
 
 import pytest
 

diff --git a/pvlib/tests/bifacial/test_losses_models.py → tests/bifacial/test_losses_models.py b/pvlib/tests/bifacial/test_losses_models.py → tests/bifacial/test_losses_models.py
diff --git a/pvlib/tests/bifacial/test_pvfactors.py → tests/bifacial/test_pvfactors.py b/pvlib/tests/bifacial/test_pvfactors.py → tests/bifacial/test_pvfactors.py
@@ -1,7 +1,7 @@
 import pandas as pd
 from datetime import datetime
 from pvlib.bifacial.pvfactors import pvfactors_timeseries
-from ..conftest import requires_pvfactors, assert_series_equal
+from tests.conftest import requires_pvfactors, assert_series_equal
 import pytest
 
 

diff --git a/pvlib/tests/bifacial/test_utils.py → tests/bifacial/test_utils.py b/pvlib/tests/bifacial/test_utils.py → tests/bifacial/test_utils.py
diff --git a/pvlib/tests/conftest.py → tests/conftest.py b/pvlib/tests/conftest.py → tests/conftest.py
@@ -70,7 +70,8 @@ def assert_frame_equal(left, right, **kwargs):
 
 # commonly used directories in the tests
 TEST_DIR = Path(__file__).parent
-DATA_DIR = TEST_DIR.parent / 'data'
+PVLIB_DATA_DIR = Path(pvlib.__path__[0]) / 'data'
+TESTS_DATA_DIR = TEST_DIR / 'data'
 
 
 # pytest-rerunfailures variables

diff --git a/pvlib/data/BIRD_08_16_2012.csv → tests/data/BIRD_08_16_2012.csv b/pvlib/data/BIRD_08_16_2012.csv → tests/data/BIRD_08_16_2012.csv
diff --git a/pvlib/data/BIRD_08_16_2012_patm.csv → tests/data/BIRD_08_16_2012_patm.csv b/pvlib/data/BIRD_08_16_2012_patm.csv → tests/data/BIRD_08_16_2012_patm.csv
diff --git a/...21 Lat_44_465 Lon_-73_205 TMY3 format.csv → ...21 Lat_44_465 Lon_-73_205 TMY3 format.csv b/...21 Lat_44_465 Lon_-73_205 TMY3 format.csv → ...21 Lat_44_465 Lon_-73_205 TMY3 format.csv
diff --git a/...03 Lat_44_4675 Lon_-73_2075 SA format.csv → ...03 Lat_44_4675 Lon_-73_2075 SA format.csv b/...03 Lat_44_4675 Lon_-73_2075 SA format.csv → ...03 Lat_44_4675 Lon_-73_2075 SA format.csv
diff --git a/...Year Lat_44_465 Lon_-73_205 SA format.csv → ...Year Lat_44_465 Lon_-73_205 SA format.csv b/...Year Lat_44_465 Lon_-73_205 SA format.csv → ...Year Lat_44_465 Lon_-73_205 SA format.csv
diff --git a/...PS SCH275KTL-DO-US-800-250kW_275kVA_1.OND → ...PS SCH275KTL-DO-US-800-250kW_275kVA_1.OND b/...PS SCH275KTL-DO-US-800-250kW_275kVA_1.OND → ...PS SCH275KTL-DO-US-800-250kW_275kVA_1.OND
diff --git a/.../data/CRNS0101-05-2019-AZ_Tucson_11_W.txt → .../data/CRNS0101-05-2019-AZ_Tucson_11_W.txt b/.../data/CRNS0101-05-2019-AZ_Tucson_11_W.txt → .../data/CRNS0101-05-2019-AZ_Tucson_11_W.txt
diff --git a/pvlib/data/CRN_with_problems.txt → tests/data/CRN_with_problems.txt b/pvlib/data/CRN_with_problems.txt → tests/data/CRN_with_problems.txt
diff --git a/pvlib/data/ET-M772BH550GL.PAN → tests/data/ET-M772BH550GL.PAN b/pvlib/data/ET-M772BH550GL.PAN → tests/data/ET-M772BH550GL.PAN
diff --git a/pvlib/data/NLD_Amsterdam062400_IWEC.epw → tests/data/NLD_Amsterdam062400_IWEC.epw b/pvlib/data/NLD_Amsterdam062400_IWEC.epw → tests/data/NLD_Amsterdam062400_IWEC.epw
diff --git a/pvlib/data/PVsyst_demo.csv → tests/data/PVsyst_demo.csv b/pvlib/data/PVsyst_demo.csv → tests/data/PVsyst_demo.csv
diff --git a/pvlib/data/PVsyst_demo_model.csv → tests/data/PVsyst_demo_model.csv b/pvlib/data/PVsyst_demo_model.csv → tests/data/PVsyst_demo_model.csv
diff --git a/pvlib/data/SRML-day-EUPO1801.txt → tests/data/SRML-day-EUPO1801.txt b/pvlib/data/SRML-day-EUPO1801.txt → tests/data/SRML-day-EUPO1801.txt
diff --git a/pvlib/data/abq19056.dat → tests/data/abq19056.dat b/pvlib/data/abq19056.dat → tests/data/abq19056.dat
diff --git a/pvlib/data/bishop88_numerical_precision.csv → tests/data/bishop88_numerical_precision.csv b/pvlib/data/bishop88_numerical_precision.csv → tests/data/bishop88_numerical_precision.csv
diff --git a/pvlib/data/bsrn-lr0100-pay0616.dat → tests/data/bsrn-lr0100-pay0616.dat b/pvlib/data/bsrn-lr0100-pay0616.dat → tests/data/bsrn-lr0100-pay0616.dat
diff --git a/pvlib/data/bsrn-pay0616.dat.gz → tests/data/bsrn-pay0616.dat.gz b/pvlib/data/bsrn-pay0616.dat.gz → tests/data/bsrn-pay0616.dat.gz
diff --git a/pvlib/data/cams_mcclear_1min_verbose.csv → tests/data/cams_mcclear_1min_verbose.csv b/pvlib/data/cams_mcclear_1min_verbose.csv → tests/data/cams_mcclear_1min_verbose.csv
diff --git a/pvlib/data/cams_mcclear_monthly.csv → tests/data/cams_mcclear_monthly.csv b/pvlib/data/cams_mcclear_monthly.csv → tests/data/cams_mcclear_monthly.csv
diff --git a/pvlib/data/cams_radiation_1min_verbose.csv → tests/data/cams_radiation_1min_verbose.csv b/pvlib/data/cams_radiation_1min_verbose.csv → tests/data/cams_radiation_1min_verbose.csv
diff --git a/pvlib/data/cams_radiation_monthly.csv → tests/data/cams_radiation_monthly.csv b/pvlib/data/cams_radiation_monthly.csv → tests/data/cams_radiation_monthly.csv
diff --git a/pvlib/data/detect_clearsky_data.csv → tests/data/detect_clearsky_data.csv b/pvlib/data/detect_clearsky_data.csv → tests/data/detect_clearsky_data.csv
diff --git a/...b/data/detect_clearsky_threshold_data.csv → ...s/data/detect_clearsky_threshold_data.csv b/...b/data/detect_clearsky_threshold_data.csv → ...s/data/detect_clearsky_threshold_data.csv
diff --git a/...b/data/greensboro_kimber_soil_manwash.dat → ...s/data/greensboro_kimber_soil_manwash.dat b/...b/data/greensboro_kimber_soil_manwash.dat → ...s/data/greensboro_kimber_soil_manwash.dat
diff --git a/pvlib/data/greensboro_kimber_soil_nowash.dat → tests/data/greensboro_kimber_soil_nowash.dat b/pvlib/data/greensboro_kimber_soil_nowash.dat → tests/data/greensboro_kimber_soil_nowash.dat
diff --git a/pvlib/data/inverter_fit_snl_meas.csv → tests/data/inverter_fit_snl_meas.csv b/pvlib/data/inverter_fit_snl_meas.csv → tests/data/inverter_fit_snl_meas.csv
diff --git a/pvlib/data/inverter_fit_snl_sim.csv → tests/data/inverter_fit_snl_sim.csv b/pvlib/data/inverter_fit_snl_sim.csv → tests/data/inverter_fit_snl_sim.csv
diff --git a/pvlib/data/ivtools_numdiff.csv → tests/data/ivtools_numdiff.csv b/pvlib/data/ivtools_numdiff.csv → tests/data/ivtools_numdiff.csv
diff --git a/pvlib/data/midc_20181014.txt → tests/data/midc_20181014.txt b/pvlib/data/midc_20181014.txt → tests/data/midc_20181014.txt
diff --git a/pvlib/data/midc_raw_20181018.txt → tests/data/midc_raw_20181018.txt b/pvlib/data/midc_raw_20181018.txt → tests/data/midc_raw_20181018.txt