Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/1238 Consistent button color schema #1315

Merged
merged 15 commits into from
Jan 23, 2025
Merged

Bug/1238 Consistent button color schema #1315

merged 15 commits into from
Jan 23, 2025

Conversation

ManuelMoeri
Copy link
Collaborator

No description provided.

@ManuelMoeri ManuelMoeri linked an issue Jan 17, 2025 that may be closed by this pull request
Konsistentes Farbschema der buttons #1238
Closed
RandomTannenbaum
RandomTannenbaum reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@RandomTannenbaum RandomTannenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method name for which I suggested a change in the first method seems to be used for every test. If you change it there you should change in the other files too.

frontend/cypress/e2e/check-in.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/check-in.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/check-in.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/key-result.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/key-result.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/team-management.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/e2e/team-management.cy.ts Outdated Show resolved Hide resolved
frontend/cypress/support/commands.ts Outdated Show resolved Hide resolved
frontend/cypress/support/helper/dom-helper/pages/overviewPage.ts Outdated Show resolved Hide resolved
frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html Outdated Show resolved Hide resolved
@ManuelMoeri ManuelMoeri marked this pull request as ready for review January 23, 2025 09:43
MasterEvarior
MasterEvarior requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, the testing can be slighty expanded by checking if there is only one primary button and there is a margin missing on one dialog. See Screenshot below.

image

frontend/cypress/e2e/objective.cy.ts Show resolved Hide resolved
ManuelMoeri and others added 15 commits January 23, 2025 13:50
@ManuelMoeri
Add solution for making button primary when needed
053ac39
@ManuelMoeri
Possibly fix problem with saving on backlog
3a42d16
@ManuelMoeri
Add E2E tests for primary buttons in the keyResult and objective dialogs
6f5ef3b
@ManuelMoeri
Generalize usage of checkForPrimaryButton in the base dialog
66eb87d
@ManuelMoeri
Fix layout mistake
4db0054
@ManuelMoeri
Add tests for team-management and fix old test to include every button
0cee4c9
@ManuelMoeri
Make command global and delete unused definitions of it
ddb9765
@ManuelMoeri
Remove unused function
3a7c021
@ManuelMoeri
Change name of ng-template to better match the content
24059be
@ManuelMoeri
Fix failing e2e test
835a960
@nevio18324 @ManuelMoeri
apply requested changes
c294a35
@nevio18324 @ManuelMoeri
use openthreedotmenu method everywhere its needed and add as param
8027704
@nevio18324 @ManuelMoeri
fix wrong state being passed as param
52b4d58
@nevio18324 @ManuelMoeri
refactor objective-form to use one save button instead of two
b8348b6
@ManuelMoeri
Fix spacing issue
db7c25f
@ManuelMoeri ManuelMoeri force-pushed the bug/1238-color-schema-buttons branch from 1ba711e to db7c25f Compare January 23, 2025 12:50
@MasterEvarior MasterEvarior merged commit 2648436 into main Jan 23, 2025
18 checks passed
@MasterEvarior MasterEvarior deleted the bug/1238-color-schema-buttons branch January 23, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomTannenbaum RandomTannenbaum RandomTannenbaum left review comments

@MasterEvarior MasterEvarior MasterEvarior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Konsistentes Farbschema der buttons
4 participants
@ManuelMoeri @MasterEvarior @RandomTannenbaum @nevio18324