Resolve the first few conversations

puzzle · Nov 11, 2024 · f8e4716 · f8e4716
1 parent e10a5e1
commit f8e4716
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 376 deletions.
diff --git a/frontend/cypress/e2e/tab.cy.ts b/frontend/cypress/e2e/tab.cy.ts
@@ -218,7 +218,7 @@ describe('Tab workflow tests', () => {
       cy.focused().parentsUntil('#objective-column').last().contains('Edited by Cypress');
     });
 
-    it.only('Duplicate objective with tab', () => {
+    it('Duplicate objective with tab', () => {
       openThreeDotMenu();
       cy.realPress('ArrowDown');
       cy.realPress('ArrowDown');
@@ -231,6 +231,7 @@ describe('Tab workflow tests', () => {
       editInputFields('Duplicated by Cypress');
       cy.tabForward();
       cy.tabForward();
+      cy.focused().contains('GJ');
       cy.realPress('ArrowDown');
       cy.realPress('ArrowDown');
       cy.tabForward();

diff --git a/frontend/src/app/components/objective/objective.component.spec.js b/frontend/src/app/components/objective/objective.component.spec.js
diff --git a/frontend/src/app/components/team-filter/team-filter.component.html b/frontend/src/app/components/team-filter/team-filter.component.html
@@ -3,7 +3,7 @@
   class="chip-list overflow-hidden w-100 d-grid"
 >
   <!-- Button to select all teams -->
-  <button (click)="toggleAll()" class="icon-button team-button focus-outline d-none d-sm-block" id="diddy">
+  <button (click)="toggleAll()" class="icon-button team-button focus-outline d-none d-sm-block">
     <mat-chip
       [attr.data-testId]="'team-filter-alle'"
       [highlighted]="activeTeams.length == (this.teams$ | async)?.length"
@@ -13,7 +13,7 @@
   </button>
   <button
     (click)="toggleSelection(team.id)"
-    *ngFor="let team of (teams$ | async)?.slice(0, showMoreTeams ? undefined : 6); trackBy: trackByFn"
+    *ngFor="let team of (teams$ | async)?.slice(0, showMoreTeams ? (teams$ | async)?.length : 6); trackBy: trackByFn"
     [attr.data-testId]="'team-filter-chip'"
     [matTooltip]="team.name"
     matTooltipPosition="above"

diff --git a/frontend/src/app/components/team-filter/team-filter.component.ts b/frontend/src/app/components/team-filter/team-filter.component.ts
@@ -1,4 +1,4 @@
-import { ChangeDetectionStrategy, Component, Input, input, OnDestroy, OnInit } from '@angular/core';
+import {ChangeDetectionStrategy, Component, OnDestroy, OnInit} from '@angular/core';
 import { BehaviorSubject, filter, Subject, Subscription, takeUntil } from 'rxjs';
 import { Team } from '../../shared/types/model/Team';
 import { TeamService } from '../../services/team.service';
@@ -20,8 +20,7 @@ export class TeamFilterComponent implements OnInit, OnDestroy {
   private unsubscribe$ = new Subject<void>();
   private subscription?: Subscription;
 
-  @Input('showMoreTeams')
-  showMoreTeams = true;
+  showMoreTeams = false;
 
   constructor(
     private teamService: TeamService,