Remove metric check-in directive and enforce number values in check-i…

…n metric value field

frontend/src/app/app.module.ts

@@ -67,7 +67,6 @@ import { CheckInFormComponent } from './components/checkin/check-in-form/check-i
 import { ApplicationTopBarComponent } from './components/application-top-bar/application-top-bar.component';
 import { A11yModule } from '@angular/cdk/a11y';
 import { CustomizationService } from './services/customization.service';
-import { MetricCheckInDirective } from './components/checkin/check-in-form-metric/metric-check-in-directive';
 
 function initOauthFactory(configService: ConfigService, oauthService: OAuthService) {
   return async() => {
@@ -122,8 +121,7 @@ export const MY_FORMATS = {
     CheckInHistoryDialogComponent,
     CheckInFormMetricComponent,
     CheckInFormOrdinalComponent,
-    CheckInFormComponent,
-    MetricCheckInDirective
+    CheckInFormComponent
   ],
   bootstrap: [AppComponent],
   schemas: [CUSTOM_ELEMENTS_SCHEMA],

frontend/src/app/components/checkin/check-in-form-metric/check-in-form-metric.component.html

@@ -11,7 +11,6 @@
               [ngClass]="formInputCheck(dialogForm, 'value')"
               formControlName="value"
               id="value"
-              metricCheckIn
             />
           </div>
 

frontend/src/app/components/checkin/check-in-form-metric/check-in-form-metric.component.spec.ts

@@ -83,4 +83,41 @@ describe('CheckInFormComponent', () => {
     expect(component.generateUnitLabel())
       .toEqual('');
   }));
+
+
+  it.each([
+    [0,
+      true],
+    [150,
+      true],
+    [-23,
+      true],
+    [12.3,
+      true],
+    [-100.3,
+      true],
+    ['123',
+      true],
+    ['-123.4',
+      true],
+    ['',
+      false],
+    ['asdf',
+      false],
+    ['a1',
+      false],
+    ['1a',
+      false],
+    [null,
+      false]
+  ])('should correctly validate value input', (value, validity) => {
+    component.dialogForm = new FormGroup({
+      value: new FormControl<string>('', [Validators.required])
+    });
+
+    component.ngOnInit();
+    component.dialogForm.setValue({ value: value });
+    expect(component.dialogForm.valid)
+      .toEqual(validity);
+  });
 });