Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BUGFIX) Exclude newest JSON version #1414

Merged
merged 1 commit into from
Nov 7, 2024
Merged

(BUGFIX) Exclude newest JSON version #1414

merged 1 commit into from
Nov 7, 2024

Conversation

david22swan
Copy link
Member

@david22swan david22swan commented Nov 7, 2024

Summary

Newest releases of the json gem have broken us, have temporarily pinned this while I reach out to the owners of the gem

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (e4dd32f) to head (a67dab4).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1414   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         127      127           
  Lines        5320     5320           
=======================================
  Hits         4708     4708           
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@david22swan david22swan marked this pull request as ready for review November 7, 2024 09:57
@david22swan david22swan requested a review from a team as a code owner November 7, 2024 09:57
@david22swan david22swan changed the title (MAINT) Exclude newest JSON version (BUGFIX) Exclude newest JSON version Nov 7, 2024
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 5efd5e9 into main Nov 7, 2024
12 checks passed
@LukasAud LukasAud deleted the json_fix branch November 7, 2024 10:36
@david22swan david22swan added the maintenance Internal maintenance work that shouldn't appear in the changelog label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix maintenance Internal maintenance work that shouldn't appear in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants