Output-ify JSON use in CreateRoleStack #1325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
justinvp
approved these changes
Feb 6, 2023
dixler
approved these changes
Mar 22, 2023
|
Given that it looks like all the AWS tests failed, it seems like we should maybe re-run the tests before merging? |
I haven't checked this actually works... |
19 tasks
rshade
force-pushed
the
fraser/createRoleStack
branch
from
bb7ed81 to
78aabbb
Compare
|
🍹 The Update for pulumi/k8s-ci-cluster/464eeb0eb3a87fcb5addda16a1dcd951266e8cd5-508 was successful. Resource Changes Name Type Operation
+ multicloud pulumi-kubernetes:ci:GkeCluster create
+ password random:index/randomPassword:RandomPassword create
+ ephemeral-ci-cluster gcp:container/cluster:Cluster create
+ primary-node-pool gcp:container/nodePool:NodePool create
+ gke pulumi:providers:kubernetes create
+ k8s-ci-cluster-464eeb0eb3a87fcb5addda16a1dcd951266e8cd5-508 pulumi:pulumi:Stack create
|
|
🍹 The Destroy for pulumi/k8s-ci-cluster/464eeb0eb3a87fcb5addda16a1dcd951266e8cd5-508 was successful. Resource Changes Name Type Operation
- ephemeral-ci-cluster gcp:container/cluster:Cluster delete
- multicloud pulumi-kubernetes:ci:GkeCluster delete
- password random:index/randomPassword:RandomPassword delete
- k8s-ci-cluster-464eeb0eb3a87fcb5addda16a1dcd951266e8cd5-508 pulumi:pulumi:Stack delete
- gke pulumi:providers:kubernetes delete
- primary-node-pool gcp:container/nodePool:NodePool delete
|
rshade
requested changes
Jan 13, 2025
| return JsonSerializer.Serialize<AssumeRolePolicyArgs>(policyArgs); | ||
| }); | ||
| AssumeRolePolicyArgs policyArgs = new AssumeRolePolicyArgs(unprivilegedUser.Arn); | ||
| var tempPolicy = Output.JsonSerialize<AssumeRolePolicyArgs>(policyArgs); |
There was a problem hiding this comment.
Suggested change
| var tempPolicy = Output.JsonSerialize<AssumeRolePolicyArgs>(policyArgs); | |
| var tempPolicy = Output.Create(policyArgs).Apply(args => JsonSerializer.Serialize(args)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.