Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render 404 with the correct status when item is not found #293

Merged
merged 6 commits into from
Jan 13, 2025
Merged

Render 404 with the correct status when item is not found #293

merged 6 commits into from
Jan 13, 2025

Conversation

hackartisan
Copy link
Member

@hackartisan hackartisan commented Jan 7, 2025 •
edited
Loading

The liveview throws an error which causes the regular view to render.

screenshot, showing 404 status in network pane:
Screenshot 2025-01-10 at 4 14 59 PM

closes #207

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Container Scanning Status: ✅ Success


ghcr.io/pulibrary/dpul-collections:pr-293 (debian 12.6)
=======================================================
Total: 0 (HIGH: 0, CRITICAL: 0)

@hackartisan hackartisan changed the title Add ItemLive.NotFoundError Render 404 with the correct status when item is not found Jan 9, 2025
@hackartisan hackartisan marked this pull request as ready for review January 10, 2025 21:32
sdellis
sdellis approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@sdellis sdellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sdellis sdellis merged commit 999491f into main Jan 13, 2025
4 checks passed
@sdellis sdellis deleted the 207-item-404 branch January 13, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdellis sdellis sdellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item page should return 404 when item not found
2 participants
@hackartisan @sdellis