Add mypy #235
Closed
Add mypy #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joostlek <[email protected]>
|
Do you guys maybe have Discord, wdyt about a discord chat so we can discuss some stuff around this? |
|
@joostlek Ping me in discord ( |
|
@joostlek I started working on strict typing on Sunday, and I have very little left to do.To coordinate efforts, don't you mind if I incorporate changes from your branch? |
|
Sure! Go ahead! |
|
Superseded by #262. Thanks for useful hints! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy is a type checking tool. IMO, typing is quite important for increasing code quality. During adding them, I also discovered several inconsistencies.
I am not expecting this to be merged right away, there are some cases where stuff is now changed where it should be different.