Fix build errors reported by gcc 14 #13856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/slic3r/GUI/Plater.cpp: In member function ‘void Slic3r::GUI::Plater::load_project(const wxString&)’:
src/slic3r/GUI/Plater.cpp:4423: error: call of overloaded ‘load_files(<brace-enclosed initializer list>)’ is ambiguous
4423 | if (! load_files({ into_path(filename) }).empty()) {
In file included from /home/asn/workspace/prj/oss/PrusaSlicer/asn-debug/src/slic3r/GUI/Plater.cpp:20:
src/slic3r/GUI/Plater.hpp:127:25: note: candidate: ‘std::vector<long unsigned int> Slic3r::GUI::Plater::load_files(const std::vector<boost::
filesystem::path>&, bool, bool, bool)’
127 | std::vector<size_t> load_files(const std::vector<boost::filesystem::path>& input_files, bool load_model = true, bool load_config = true, bool imperial_units = false);
| ^~~~~~~~~~
src/slic3r/GUI/Plater.hpp:131:10: note: candidate: ‘bool Slic3r::GUI::Plater::load_files(const wxArrayString&, bool)’
131 | bool load_files(const wxArrayString& filenames, bool delete_after_load = false);
| ^~~~~~~~~~
src/slic3r/GUI/PhysicalPrinterDialog.cpp: In member function ‘void Slic3r::GUI::PhysicalPrinterDialog::build_printhost_settings(Slic3r::GUI::ConfigOptionsGroup*)’:
/home/asn/workspace/prj/oss/PrusaSlicer/asn-debug/src/slic3r/GUI/PhysicalPrinterDialog.cpp:610: error: call of overloaded ‘set_values(<brace-enclosed initializer list>)’ is ambiguous
610 | choice->set_values({ m_config->opt_string("printhost_port") });
In file included from /home/asn/workspace/prj/oss/PrusaSlicer/asn-debug/src/slic3r/GUI/OptionsGroup.hpp:24,
from /home/asn/workspace/prj/oss/PrusaSlicer/asn-debug/src/slic3r/GUI/Search.hpp:24,
from /home/asn/workspace/prj/oss/PrusaSlicer/asn-debug/src/slic3r/GUI/MainFrame.hpp:30,
from /home/asn/workspace/prj/oss/PrusaSlicer/asn-debug/src/slic3r/GUI/PhysicalPrinterDialog.cpp:31:
src/slic3r/GUI/Field.hpp:446:33: note: candidate: ‘void Slic3r::GUI::Choice::set_values(const std::vector<std::__cxx11::basic_string<char> >
&)’
446 | void set_values(const std::vector<std::string> &values);
| ^~~~~~~~~~
src/slic3r/GUI/Field.hpp:447:33: note: candidate: ‘void Slic3r::GUI::Choice::set_values(const wxArrayString&)’
447 | void set_values(const wxArrayString &values);
| ^~~~~~~~~~
src/slic3r/Utils/OctoPrint.cpp: In lambda function:
src/slic3r/Utils/OctoPrint.cpp:754:36: error: operands to ‘?:’ have
different types ‘std::wstring’ {aka ‘std::__cxx11::basic_string<wchar_t>
’} and ‘wxString’
754 | si.name = name ? boost::nowide::widen(*name) : wxString();
| ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Related to PR #11769 ? |
|
Yeah, it is more or less exactly the same. |
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 14 reports ambiguous function calls and ternary type mismatches. The patches of this PR address those issues.