Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that Map fields cannot be optional #200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rossng
Copy link

@rossng rossng commented Dec 6, 2024

This tripped me up: the documentation explicitly says that Map fields cannot be repeated, but it doesn't mention optional.

When trying to compile protobufs with a map<string, Foo>`, I get the following error:

rpc.proto:121:19:syntax error: unexpected '<'
rpc.proto:121:48:syntax error: unexpected '>'

See also: protobufjs/protobuf.js#429

Copy link

google-cla bot commented Dec 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rossng
Copy link
Author

rossng commented Dec 6, 2024

I generally don't sign CLAs. This change is so trivial that it's not copyrightable IMO - feel free to rewrite it yourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant