Tiny semantic fix in RepeatedPtrOverPtrsIterator (NFC)

The original code worked in practice only because the pointed-to type is always `void`, and `void**` is convertible to `void*` (ignoring constness). PiperOrigin-RevId: 719003773
protocolbuffers · Jan 23, 2025 · 565fada · 565fada
1 parent 7878682
commit 565fada
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/google/protobuf/repeated_ptr_field.h b/src/google/protobuf/repeated_ptr_field.h
@@ -1736,7 +1736,7 @@ class RepeatedPtrOverPtrsIterator {
       typename OtherElement, typename OtherVoidPtr,
       typename std::enable_if<
           std::is_convertible<OtherElement*, pointer>::value &&
-          std::is_convertible<OtherVoidPtr*, VoidPtr>::value>::type* = nullptr>
+          std::is_convertible<OtherVoidPtr, VoidPtr>::value>::type* = nullptr>
   RepeatedPtrOverPtrsIterator(
       const RepeatedPtrOverPtrsIterator<OtherElement, OtherVoidPtr>& other)
       : it_(other.it_) {}