Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event carousel accentColor #2183

Merged
merged 1 commit into from
Jan 6, 2025
Merged

event carousel accentColor #2183

merged 1 commit into from
Jan 6, 2025

Conversation

rrrliu
Copy link
Collaborator

@rrrliu rrrliu commented Dec 10, 2024

accentColor is now configurable, rather than being only purple / orange

unfortunately this also means another ITicketData / IPODTicketData field, so we may need to remove another field with #2151

Screen.Recording.2024-12-09.at.4.57.47.PM.mov

@rrrliu rrrliu requested a review from robknight December 10, 2024 01:01
Copy link
Member

@robknight robknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I do notice that the accent color is not available for CSVTicketPipeline - do we think we'll need it for that?

Also flagging up for @artwyman that this will add another entry to POD tickets, which might affect Merkle tree depths in the long run.

@artwyman
Copy link
Member

Thanks for the callout. Note that I closed #2151 figuring that now that we're out of the Devcon crisis mode we'd prefer other solutions. We can re-open it if we decide otherwise. I think the best answer is distribute artifacts which support a deeper Merkle tree, rather than forcing tickets to stay below 16 entries. There is a cost (adding 1 depth means 1 more Poseidon hash per entry in the circuit), but likely it's not big enough to be worth limiting our use cases too much. We should be watchful going forward for the point where we might cross further thresholds (32 would be next) if we haven't fleshed out the artifacts enough to cover all cases.

For this feature in particular, it seems a bit of a shame that this info has to go into every ticket rather than some sort of per-event metadata POD, but it would take a larger set of changes to distribute those.

@rrrliu rrrliu added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit 6cea67c Jan 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants