Format error messages as text to avoid XSS vulnerabilities #2161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark error messages from api.zupass.org as text to ensure any <script> tags in them are not executed. Those could come directly from user input.
This was reported by Andrew (a different one, not me) at Devcon. The risk here is low since api.zupass.org is a different domain with no sensitive data in cookies or local storage, but still good to clean up the risk that users could be tricked into something dangerous.
Two test URLs which demonstrate script injection via URL parameters on api.zupass.org:
Here are versions of those URLs which demonstrate the issue on my local test server:
Attn: @antimatter15 who submitted an initial version of this in #2159 .