Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-launch styling followups #2136

Merged
merged 7 commits into from
Nov 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nites
rrrliu committed Nov 8, 2024
commit 204061ba37de2dd8c2ae34c12c95cdc76ee33b82
Original file line number Diff line number Diff line change
@@ -181,7 +181,7 @@
const isSyncSettled = useIsSyncSettled();
const [params, setParams] = useSearchParams();
const [zappUrl, setZappUrl] = useState("");
const [holding, setHolding] = useState(false);

Check failure on line 184 in apps/passport-client/new-components/screens/Home/NewHomeScreen.tsx

GitHub Actions / Build-and-Test

'holding' is assigned a value but never used. Allowed unused vars must match /^_/u
const isInvalidUser = useUserForcedToLogout();
const location = useLocation();
const regularParams = useParams();
@@ -393,9 +393,6 @@
onMouseDown={() => setHolding(true)}
onMouseUp={() => setHolding(false)}
onMouseLeave={() => setHolding(false)}
style={{
cursor: holding ? "grabbing" : "grab"
}}
>
<_SwipableViews
style={{
2 changes: 1 addition & 1 deletion apps/passport-client/src/password.ts
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ export const setPassword = async (
);
} else if (res.error.name === "Conflict") {
update({ extraDownloadRequested: true });
throw new Error(`Cannot change password while PCDs are syncing.
throw new Error(`Cannot change password while PODs are syncing.
Wait for download to complete or reload the page and try again.`);
} else {
throw new Error(