eddsa poseidon update #2079
Merged
eddsa poseidon update #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robknight
approved these changes
Oct 31, 2024
|
Thanks @artwyman @robknight is this an issue with |
I'm not sure. I am trying to avoid CommonJS-only packages where possible, as they seem to have more compatibility issues, but I don't think that there's anything that you can do about this particular issue. |
|
This is ready to go, but I'm holding it back until after Devcon to minimize risk. |
# Conflicts: # packages/lib/pod/package.json # packages/pcd/eddsa-pcd/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This steals the build fix from #2076 to make unit tests work. Thanks @robknight.
Attn: @cedoor regarding the packaging issue we're working around. If you grab this branch and remove the build config change, you'll see the error. Probably something zk-kit needs to either fix, or document for other devs.