feat: better error checking

proofcarryingdata · Nov 8, 2024 · 35076b7 · 35076b7
1 parent c989ade
commit 35076b7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/apps/passport-server/src/routing/routes/genericIssuanceRoutes.ts b/apps/passport-server/src/routing/routes/genericIssuanceRoutes.ts
@@ -808,11 +808,10 @@ export function initGenericIssuanceRoutes(
       }
 
       if (!main.length) {
-        const errorPage = await readFileWithCache(
-          absPath.replace("index", "error")
+        throw new PCDHTTPError(
+          400,
+          `No ticket found with order code ${code} and email ${email}. Please contact [email protected] immediately.`
         );
-        res.send(errorPage);
-        return;
       }
 
       const file = await readFileWithCache(absPath);

diff --git a/apps/passport-server/src/services/generic-issuance/GenericIssuanceService.ts b/apps/passport-server/src/services/generic-issuance/GenericIssuanceService.ts
@@ -445,10 +445,7 @@ export class GenericIssuanceService {
       (atom) => atom.orderCode === orderCode
     );
     if (!validAtom) {
-      throw new PCDHTTPError(
-        400,
-        `No ticket found with order code ${orderCode} and email ${email}`
-      );
+      return { tickets: [] } satisfies TicketPreviewResultValue;
     }
 
     const ticketDatas = tickets.atoms.map(