opsgenie : trim space for api key file #4195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
approved these changes
Jan 6, 2025
|
LGTM. Could you please write a unit test for this too? |
zoov-xavier
force-pushed
the
opsgenie_trim_api_key_file
branch
3 times, most recently
from
5ae2c11 to
143e02f
Compare
Signed-off-by: zoov-xavier <[email protected]>
zoov-xavier
force-pushed
the
opsgenie_trim_api_key_file
branch
from
143e02f to
cd1de9c
Compare
|
Hello, @grobinson-grafana thanks for the review. I added some tests. Let me know if any updates are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to trim the spaces on the API key file for Opsgenie as it is already done for most other integrations (Slack, Discord, PagerDuty, etc.)