Add support for custom template versions for dependency update and sync #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make use of the native support for specifying a template version in Cruft to pass through a custom version in dependency update and sync. We introduce flag `--template-version` for the component and package `update` and `sync` commands. Resolves #618
simu
changed the title
simu
force-pushed
the
feat/template-version-update-sync
branch
3 times, most recently
from
3ee2ff8 to
f259a06
Compare
This should reduce the code complexity of each method as well as allowing us to write simpler tests for the dependency syncing mechanism.
simu
force-pushed
the
feat/template-version-update-sync
branch
from
f259a06 to
295bd57
Compare
We don't want to see diffs when running `sync` with a custom template version, since this flag is primarily intended to be run on template repo PRs where we don't care that the template version changes since the actual change will only be applied once we merge the PR.
DebakelOrakel
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make use of the native support for specifying a template version in Cruft to pass through a custom version in dependency update and sync.
We introduce flag
--template-versionfor the component and packageupdateandsynccommands.Resolves #618
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog