Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump ember-intl from 6.3.2 to 6.4.0 #296

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 15, 2023

Bumps ember-intl from 6.3.2 to 6.4.0.

Release notes

Sourced from ember-intl's releases.

Improved DX and deprecated macros

What changed?

  • Allowed test helpers setLocale() and addTranslation() to call settled()
  • Updated documentation for testing
  • Fixed type errors caused by macros
  • Deprecated macros (to be removed in v7.0.0)
  • Improved \<template>-tag support (allowed importing helpers from index)

Migration guide

Test helpers

Before v6.4.0, calling setLocale() and addTranslations() wouldn't have an effect on the application in tests. You might have had to call await settled() or use something from @ember/runloop to trigger an update.

Now, the test helpers handle the update and mean the following in tests:

  • setLocale() - update the locale as if the user had somehow changed their preferred language
  • addTranslations() - update the translations as if you had somehow added them (e.g. via lazy loading)

You will want to search your test files for setLocale(, addTranslations(, and ember-intl/test-support, then migrate code as follows:

- import { render, settled } from '@ember/test-helpers';
+ import { render } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';
import { setLocale, setupIntl } from 'ember-intl/test-support';
import { setupRenderingTest } from 'ember-qunit';
import { module, test } from 'qunit';
module('Integration | Component | hello', function (hooks) {
setupRenderingTest(hooks);
setupIntl(hooks);
test('it renders', async function (assert) {
await render(hbs&lt;Hello @name=&quot;Zoey&quot; /&gt;);
assert.dom('[data-test-message]').hasText('Hello, Zoey!');



setLocale('de-de');



await settled();





await setLocale('de-de');



</tr></table>

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ember-intl](https://github.com/ember-intl/ember-intl) from 6.3.2 to 6.4.0.
- [Release notes](https://github.com/ember-intl/ember-intl/releases)
- [Changelog](https://github.com/ember-intl/ember-intl/blob/main/docs-app/CHANGELOG.md)
- [Commits](ember-intl/ember-intl@v6.3.2...v6.4.0)

---
updated-dependencies:
- dependency-name: ember-intl
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 15, 2023
@Yelinz Yelinz merged commit e82539c into main Dec 15, 2023
12 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/ember-intl-6.4.0 branch December 15, 2023 12:03
@anehx
Copy link
Contributor

anehx commented Jun 26, 2024

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@anehx anehx added the released label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants