Shim SlippiDirectCodes to Rust port. #417
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes out the internals of the `SlippiDirectCodes` class, wherein it'll now just silently call over to the Rust side. This keeps the changes minimal for now as we continue to migrate things out. There is a small change here to `FileUtil` to have it return a folder path rather than a file path; the Rust layer will extend that path with whatever it needs (e.g `user.json`). This compiles but has not been fully tested/vetted yet. Building this branch currently requires the corresponding branch from slippi-rust-extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes out the internals of the
SlippiDirectCodesclass, wherein it'll now just silently call over to the Rust side. This keeps the changes minimal for now as we continue to migrate things out - no core logic changes required by doing it this way.There is a small change here to
FileUtilto have it return a folder path rather than a file path; the Rust layer will extend that path with whatever it needs (e.guser.json).This compiles but has not been fully tested/vetted yet. Building this branch currently requires the corresponding branch from slippi-rust-extensions. I'll do this same PR for the mainline build as well.