-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch and display image thumbnails in the timeline instead of the full-resolution image #322
base: main
Are you sure you want to change the base?
Conversation
@kevinaboos robrix/src/shared/text_or_image.rs Line 40 in 905bc2d
There are a few of points confusing me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinaboos Thanks for noticing this comment. I have finished the task1 while there is no need to review this time. Now I am working on task2, which shoud make the image clickable as first step. I change
View
toClickableView
here:
Let's keep this PR simple and focused on just one thing -- the thumbnail support, which you've called "task1". We can handle task2 later in a separate PR, as it is easier to review multiple smaller PRs instead of one big PR.
So, please address my one comment, and clean up this PR such that it only includes changes related to thumbnails.
There are a few of points confusing me:
- There is no any widgets in robrix rely on
ClickableView
inshared/clickable_view.rs
.- I have tested
ClickableView
for many times and seems it cannot work. And One widget calledRoomPreview
, which is aView
, impl the clickable function itself instead relying onClickableView
Ah yes, ClickableView
is no longer used and should be removed. Please don't use that for task2. We'll remove that code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the new code to fetch the thumbnail or the full-size image as a fallback looks good now.
Please remove all ImageViewer
stuff from this PR so I can merge in only the thumbnail-related changes. You can add the ImageViewer
back in as part of a future PR.
I am using commit 50f662a |
issue #271
To-do before merge: