Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch and display image thumbnails in the timeline instead of the full-resolution image #271

Open
kevinaboos opened this issue Nov 22, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Looking for help from anyone!

Comments

@kevinaboos
Copy link
Member

kevinaboos commented Nov 22, 2024

Currently Robrix always requests the full-resolution image when displaying MessageType::Images in the timeline. This is unnecessary and wasteful, both in terms of bandwidth usage and in terms of the performance cost of decoding the full image.

The original reason behind this is that very early versions of Robrix and/or the Matrix SDK had problems properly retrieving a thumbnail-sized image. But that should work properly now.

Thus, we should request thumbnails of each image in the timeline instead of the full image.


The second part of this is to actually fetch the full image when the user clicks an image thumbnail, and then display that image in a full-screen view.
This can be done as part of this issue, or left to a future separate issue, as it requires more effort to design and implement a pop-up image viewer with a loading spinner.

@kevinaboos kevinaboos changed the title But really, we should be displaying thumbnails in the timeline, and only fetch the full image when the user clicks said image preview. Display image **thumbnails** in the timeline instead of the full-quality image. Only fetch the full image when the user clicks said image preview. Nov 22, 2024
@kevinaboos kevinaboos changed the title Display image **thumbnails** in the timeline instead of the full-quality image. Only fetch the full image when the user clicks said image preview. Display image thumbnails in the timeline instead of the full-quality image. Only fetch the full image when the user clicks said image preview. Nov 22, 2024
@kevinaboos kevinaboos added enhancement New feature or request good first issue Good for newcomers help wanted Looking for help from anyone! labels Nov 22, 2024
@kevinaboos kevinaboos changed the title Display image thumbnails in the timeline instead of the full-quality image. Only fetch the full image when the user clicks said image preview. Fetch and display image thumbnails in the timeline instead of the full-quality image Nov 22, 2024
@kevinaboos kevinaboos changed the title Fetch and display image thumbnails in the timeline instead of the full-quality image Fetch and display image thumbnails in the timeline instead of the full-resolution image Nov 22, 2024
@github-project-automation github-project-automation bot moved this to Ready in Robrix Nov 22, 2024
@aaravlu
Copy link
Contributor

aaravlu commented Jan 10, 2025

I shall fix this issue if none is working on this.

@kevinaboos
Copy link
Member Author

I shall fix this issue if none is working on this.

Great! Yeah, nobody is working on it AFAIK, so it's available. I'll assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Looking for help from anyone!
Projects
Status: Ready
Development

No branches or pull requests

2 participants