Support multiple device type with primary type #1034
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brdandu @tecimovic @aspecter what about Zigbee? |
|
Primary device types are defined, right? How would the GUI handle this? How would a user know which device types to include in the subset of the superset? They would look at the spec? Is the plan to allow any device type combo and just let the user mess up? |
…is comment later Github: ZAP#862
…nge with the introduction of Endpoint_type_device table Github: ZAP#682
…ce types per endpoint Github: ZAP#862
… update the multiple zcl device types correctly Github: ZAP#862
Github: ZAP#862
…ype profile id per endpoint for backwards compatibility Github: ZAP#862
…per endpoint are updated correctly Github: ZAP#862
Github: ZAP#862
…y useful in any way Github: ZAP#862
…is edited and a new zcl device type is added to the endpoint Github: ZAP#862
…devices do not show up in the device UI. Updating deviceIdentifier with this.zclDeviceTypes[deviceTypeRefs[i]].code fixed it Github: ZAP#862
…is comment later Github: ZAP#862
…nge with the introduction of Endpoint_type_device table Github: ZAP#682
…ce types per endpoint Github: ZAP#862
… update the multiple zcl device types correctly Github: ZAP#862
Github: ZAP#862
aspecter
force-pushed
the
multiple-device-type
branch
from
83971b5 to
95f06e0
Compare
…erEndpoint/ZAP#862' into multiple-device-type
…device junction table instead of keeping it in endpoint table such that multiple zcl device types can be added per endpoint. Schema change lead to the rest of the changes in queries for endpoint_type, endpoint_type_device and endpoint tables along with UI changes to vue files, actions and mutations. Github: ZAP#862
…erEndpoint/ZAP#862' into multiple-device-type
…instead of endpoint just like device type ref - Updating db-mapping to have device version and identifier in endpoint_type - Fixing query-config#updateEndpointType to add the entries properly to endpoint_type and endpoint_type_device tables - Use endpoint_type_device table in a bunch of queries instead of endpoint_type to get references to device version and identifier - Fix import isc with the new schema - Fix edit and update endpoint by fixing httpPatchEndpointType with respect to device version and identifier - Fix Create endpoint UI and endpoint card such that device identifier and device version can be updated properly through the UI - Fixing actions and mutations for device version and identifier for an endpoint type such that UI and backend are in sync - Updating state.js such that device version and identifier are in endpoint type instead of endpoint now - Minor cleanup - Github: ZAP#862
…nd device version/identifier Github: ZAP#862
…g of zap files continues to give the right results when multiple zcl device types are chosen Github: ZAP#862
… multiple-device-type
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
- Coverage 65.52% 65.43% -0.10%
==========================================
Files 170 170
Lines 17632 17769 +137
Branches 3787 3834 +47
==========================================
+ Hits 11554 11627 +73
- Misses 6078 6142 +64
|
…ests include adding a new endpoint and editing an existing endpoint Github: ZAP#862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.