Stream oprf ipa #827
Merged
Stream oprf ipa #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminsavage
requested review from
martinthomson,
richajaindce and
akoshelev
|
This branch was landed as a result of landing #829 |
|
Actually it wasn't landed... how confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the new OPRF approach of IPA to use streaming.
Can no longer separate out the aggregation stage into a separate function because streams are just super hard to use. But there was no other place in the code that we were calling that, so OK.
Also had to eliminate a bunch of tests (that arguably were not good tests) that were testing just the first step or just the second step in isolation.