Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web-based encryption recommendation #2339

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

freddy-m
Copy link
Member

Changes proposed in this PR:

  • Remove browser-based encryption recommendations (hat.sh hasn't had a commit since June 2022)
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@freddy-m freddy-m added the c:software self-hosted/decentralized software and related topics label Nov 23, 2023
Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 239ac0d
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/6564daf5cc71a9000831b482
😎 Deploy Preview https://deploy-preview-2339.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 78 (🟢 up 4 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@freddy-m freddy-m self-assigned this Nov 23, 2023
@freddy-m freddy-m requested review from dngray and jonaharagon and removed request for dngray November 24, 2023 11:38
@dngray
Copy link
Member

dngray commented Nov 24, 2023

Just thought I'd note here, we're not removing this because of any known security vulnerabilities.

It uses a libsodium wrapper (around libsodium) which is a maintained library, the concern is that there are other libraries react, etc that are not up to date as this project doesn't appear to be maintained anymore. Original author has no activity whatsoever for over a year.

I seem to recall the original suggestion for this application was for ChromeOS users on locked down hardware - realistically there though, hardware managed by an organization has very little privacy when compared to a personal device.

Therefore in support of removing this. If you have control over what apps you can install there are other options Cryptomator, etc.

@dngray dngray changed the title Remove browser-based encryption recommendations Remove web-based encryption recommendation Nov 27, 2023
@dngray dngray force-pushed the removed-browswer-encryption branch from a296ce1 to 239ac0d Compare November 27, 2023 18:07
@dngray dngray merged commit 239ac0d into main Nov 27, 2023
3 checks passed
@dngray dngray deleted the removed-browswer-encryption branch November 27, 2023 18:08
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/is-there-any-veracrypt-alternative-on-android/17402/6

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-19/16257/1

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/remove-fluent-reader/22085/1

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides Community. There might be relevant details there:

https://discuss.privacyguides.net/t/has-hat-sh-development-ceased/23620/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:software self-hosted/decentralized software and related topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants