Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: r1cs iteration exit once section 1 read #240

Merged
merged 1 commit into from
Dec 29, 2023
Merged

fix: r1cs iteration exit once section 1 read #240

merged 1 commit into from
Dec 29, 2023

Conversation

glamperd
Copy link
Contributor


name: Pull Request
about: Open a PR for p0tion

Description

The logic only requires section 1 of the r1cs to be read. The pointer increments incorrectly if it is allowed to iterate beyond section 1, causing errors.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [ x] Test with r1cs file that was previously failing

Checklist:

  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [ x] Any dependent changes have been merged and published in downstream modules
  • [ x] I reviewed the code of conduct and contributors' guide

@glamperd glamperd self-assigned this Dec 12, 2023
@ctrlc03 ctrlc03 linked an issue Dec 12, 2023 that may be closed by this pull request
@ctrlc03 ctrlc03 self-requested a review December 12, 2023 14:17
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to see an example of this working and previous code failing? Other than that, LGTM

@ctrlc03 ctrlc03 merged commit b2aff97 into dev Dec 29, 2023
1 check failed
@ctrlc03 ctrlc03 deleted the 239-r1cs-info branch December 29, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R1CS info retrieval fails
2 participants