Skip to content

Commit

Permalink
Merge pull request #232 from shuoer86/dev
Browse files Browse the repository at this point in the history
chore: fix typos
  • Loading branch information
ctrlc03 authored Nov 2, 2023
2 parents c749be4 + 6dbfebb commit b9e05e4
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/actions/.env.default
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# This environemnt must be configured both for core functionalities and testing.
# This environment must be configured both for core functionalities and testing.
# The tests can be executed against a pre-deployed Firebase instance or
# locally on your machine using the Firebase emulator.

Expand Down Expand Up @@ -37,7 +37,7 @@ CONFIG_CEREMONY_BUCKET_POSTFIX="-ph2-ceremony"
# The amount of time in seconds which indicates the duration about the validity of a pre-signed URL.
# default: 7200 seconds = 2 hours.
CONFIG_PRESIGNED_URL_EXPIRATION_IN_SECONDS=7200
# AWS S3 access keys only required for unit/e2e testing (can be ommited)
# AWS S3 access keys only required for unit/e2e testing (can be omitted)
# The AWS access key identifier related to S3 APIs.
AWS_ACCESS_KEY_ID="YOUR-AWS-ACCESS-KEY-ID"
# The AWS secret access key related to S3 APIs.
Expand Down
2 changes: 1 addition & 1 deletion packages/actions/src/types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ export type VMConfiguration = {
/**
* Group information about the circuit contribution verification mechanism.
* @typedef {Object} CircuitContributionVerification
* @property {CircuitContributionVerificationMechanism} cfOrVm - the mechanism choosen by the coordinator.
* @property {CircuitContributionVerificationMechanism} cfOrVm - the mechanism chosen by the coordinator.
* @property {VMConfiguration} [vm] - the VM configuration specs.
*/
export type CircuitContributionVerification = {
Expand Down
2 changes: 1 addition & 1 deletion packages/actions/test/unit/contribute.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ describe("Contribute", () => {
resumeContributionAfterTimeoutExpiration(userFunctions, fakeCeremoniesData.fakeCeremonyOpenedFixed.uid)
).to.be.rejectedWith("Unable to progress to next circuit for contribution")
})
it("should succesfully resume the contribution", async () => {
it("should successfully resume the contribution", async () => {
await signInWithEmailAndPassword(userAuth, users[0].data.email, passwords[0])
await expect(
resumeContributionAfterTimeoutExpiration(userFunctions, fakeCeremoniesData.fakeCeremonyOpenedFixed.uid)
Expand Down
2 changes: 1 addition & 1 deletion packages/actions/test/unit/finalize.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ describe("Finalize", () => {
)
).to.be.rejectedWith("Unable to download the AWS S3 object from the provided ceremony bucket.")
})
it("should succesfully finalize the last contribution", async () => {
it("should successfully finalize the last contribution", async () => {
// prepare coordinator for finalization
await checkAndPrepareCoordinatorForFinalization(
userFunctions,
Expand Down
2 changes: 1 addition & 1 deletion packages/actions/test/unit/security.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@ describe("Security", () => {
})
/// @note these test should be running last
if (envType === TestingEnvironment.PRODUCTION) {
/// @note it is not recommended to allow anynomous access to firebase
/// @note it is not recommended to allow anonymous access to firebase
it("should not allow to authenticate anynomously to Firebase", async () => {
const auth = getAuth()
await expect(signInAnonymously(auth)).to.be.rejectedWith(
Expand Down
2 changes: 1 addition & 1 deletion packages/actions/test/unit/storage.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ describe("Storage", () => {
const exists = await checkIfObjectExist(userFunctions, bucketName, objectName)
expect(exists).to.be.equal(true)
})
it("should return false when given a non existant bucket name", async () => {
it("should return false when given a non existent bucket name", async () => {
// check existence
const exists = await checkIfObjectExist(userFunctions, "nonExistingBucket", objectName)
expect(exists).to.be.equal(false)
Expand Down
2 changes: 1 addition & 1 deletion packages/backend/src/functions/ceremony.ts
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ export const finalizeCeremony = functions
const circuits = await getCeremonyCircuits(ceremonyId)

// Get final contribution for each circuit.
// nb. the `getFinalContributionDocument` checks the existance of the final contribution document (if not present, throws).
// nb. the `getFinalContributionDocument` checks the existence of the final contribution document (if not present, throws).
// Therefore, we just need to call the method without taking any data to verify the pre-condition of having already computed
// the final contributions for each ceremony circuit.
for await (const circuit of circuits) await getFinalContribution(ceremonyId, circuit.id)
Expand Down

0 comments on commit b9e05e4

Please sign in to comment.