Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Multigrid support #401

Draft
wants to merge 17 commits into
base: devel
Choose a base branch
from

Conversation

landinjm
Copy link
Contributor

@landinjm landinjm commented Jan 14, 2025

Do not review. Posted to collaborate with @fractalsbyx.

Summary of issues that are closed:
#394, #398. #386, #376, #409, #393, #294, #329, #313, #276, #290, #311

Issues in progress
#351
#346
#323
#301
#291
#285
#273
#253
#218
#210
#174
#90
#86
#65

@landinjm
Copy link
Contributor Author

landinjm commented Jan 14, 2025

We can just integrate the work in #379 as we rebuild computeRHS, computeLHS & postprocess.

@landinjm landinjm force-pushed the refactor_PDE_operator branch from 90eaee1 to f0f68f6 Compare January 15, 2025 22:23
@landinjm
Copy link
Contributor Author

VariableValueContainer can be deleted too

@landinjm
Copy link
Contributor Author

landinjm commented Jan 16, 2025

Checklist of features left to integrate

  • AMR
  • Newton update & nonlinear solves
  • Multiple equations
  • User-facing implementations
  • Initial conditions
  • Boundary conditions
  • Grain growth features
  • User-controlled inputs
  • File read-in
  • Checkpoints
  • Transient problems
  • Nucleation

@landinjm landinjm force-pushed the refactor_PDE_operator branch from d700e6c to 82c1ec9 Compare January 22, 2025 02:44
@landinjm
Copy link
Contributor Author

landinjm commented Jan 22, 2025

For 1D support it would nice to not change any potential indexing for vector fields when switching to 1D. In the get_vector_* commands we should add something to avoid switching return types:

  using vectorValue = typename std::conditional<
    dim == 1,
    dealii::VectorizedArray<number>,
    dealii::Tensor<1, dim, dealii::VectorizedArray<number>>>::type;
  using vectorGrad = typename std::conditional<
    dim == 1,
    dealii::Tensor<1, dim, dealii::VectorizedArray<number>>,
    dealii::Tensor<2, dim, dealii::VectorizedArray<number>>>::type;
  using vectorHess = typename std::conditional<
    dim == 1,
    dealii::Tensor<2, dim, dealii::VectorizedArray<number>>,
    dealii::Tensor<3, dim, dealii::VectorizedArray<number>>>::type;

This is done

@landinjm landinjm changed the title [WIP] Refactor PDE operator for multigrid [WIP] Multigrid support Jan 22, 2025
@landinjm
Copy link
Contributor Author

For the new variableAttributes we should test the most efficient method of lookup (see here) since the evaluation flags are passed for every cell.

@landinjm
Copy link
Contributor Author

Should add more units tests for variableAttributes now that there's more working parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant