fix(query-core): enable null_serialization_error #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkomyno
commented
Jan 13, 2025
Comment on lines
297
to
-299
| } else if items.is_empty() && opt { | ||
| Ok((parent, Item::Ref(ItemRef::new(Item::Value(PrismaValue::Null))))) | ||
| } else if items.is_empty() && opt { |
There was a problem hiding this comment.
Notice how these two conditions were identical, and hence the second one would never be conditionally chosen.
CodSpeed Performance ReportMerging #5120 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT
Let's see what happens to our tests.
Ref: #2979.