Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query-engine-wasm): share generics across compilation units #5048

Closed
wants to merge 1 commit into from
Closed

chore(query-engine-wasm): share generics across compilation units #5048

wants to merge 1 commit into from

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Nov 16, 2024

No description provided.

@aqrln aqrln requested a review from a team as a code owner November 16, 2024 17:31
@aqrln aqrln requested review from jkomyno and removed request for a team November 16, 2024 17:31
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #5048 will not alter performance

Comparing wasm-share-generics (81e1b17) with main (378004b)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.032MiB 2.032MiB 0.000B
Postgres (gzip) 816.876KiB 816.877KiB -1.000B
Mysql 1.995MiB 1.995MiB 0.000B
Mysql (gzip) 802.622KiB 802.624KiB -2.000B
Sqlite 1.895MiB 1.895MiB 0.000B
Sqlite (gzip) 763.269KiB 763.271KiB -2.000B

@aqrln aqrln closed this Nov 16, 2024
@aqrln aqrln deleted the wasm-share-generics branch November 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aqrln