Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

driver-adapters: fix benchmark runner on Node.js 20+ #4664

Merged
merged 2 commits into from
Jan 22, 2024
Merged

driver-adapters: fix benchmark runner on Node.js 20+ #4664

merged 2 commits into from
Jan 22, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jan 22, 2024 •
edited
Loading

Similar to #4642

@aqrln aqrln requested a review from a team as a code owner January 22, 2024 12:22
@aqrln aqrln requested review from laplab and Druue and removed request for a team January 22, 2024 12:22
@aqrln aqrln changed the title driver-adapters: fix benchmark executor on Node.js 20+ driver-adapters: fix benchmark runner on Node.js 20+ Jan 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

WASM Size

Engine This PR Base branch Diff
WASM 2.338MiB 2.338MiB 0.000B
WASM (gzip) 907.885KiB 907.885KiB 0.000B

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited
Loading

✅ WASM query-engine: no benchmarks have regressed

Full benchmark report 
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs

After changes in 0e677da

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4664 will not alter performance

Comparing driver-adapters-fix-benchmark-executor-on-node.js-20 (0e677da) with main (c71605d)

Summary

✅ 11 untouched benchmarks

@aqrln aqrln added this to the 5.9.0 milestone Jan 22, 2024
@aqrln aqrln self-assigned this Jan 22, 2024
@aqrln aqrln merged commit 0e77726 into main Jan 22, 2024
114 checks passed
@aqrln aqrln deleted the driver-adapters-fix-benchmark-executor-on-node.js-20 branch January 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@SevInf SevInf SevInf approved these changes

@laplab laplab Awaiting requested review from laplab laplab is a code owner automatically assigned from prisma/orm-rust

@Druue Druue Awaiting requested review from Druue Druue is a code owner automatically assigned from prisma/orm-rust

Assignees

@aqrln aqrln

Labels
None yet
Projects
None yet
Milestone
5.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aqrln @SevInf @Jolg42