Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nix): update flake for Rust 1.75.0 #4626

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Jan 2, 2024

nix flake update

@jkomyno jkomyno self-assigned this Jan 2, 2024
@jkomyno jkomyno added this to the 5.8.0 milestone Jan 2, 2024
@jkomyno jkomyno added the dependencies Pull requests that update a dependency file label Jan 2, 2024
@jkomyno jkomyno marked this pull request as ready for review January 2, 2024 13:15
@jkomyno jkomyno requested a review from a team as a code owner January 2, 2024 13:16
@jkomyno jkomyno requested review from miguelff and laplab and removed request for a team January 2, 2024 13:16
Copy link
Contributor

github-actions bot commented Jan 2, 2024

WASM Size

Engine This PR Base branch Diff
WASM 2.748MiB 2.744MiB 4.099KiB
WASM (gzip) 1.009MiB 1.006MiB 3.351KiB

Copy link

codspeed-hq bot commented Jan 2, 2024

CodSpeed Performance Report

Merging #4626 will not alter performance

Comparing feat/nix-update-flake-for-rust-1.75.0 (d9e3510) with main (fecfd2f)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jan 2, 2024

🚨 WASM query-engine: 1 benchmark(s) have regressed at least 2%

Full benchmark report
DATABASE_URL="postgresql://postgres:postgres@localhost:5432/bench?schema=imdb_bench&sslmode=disable" \
node --experimental-wasm-modules query-engine/driver-adapters/executor/dist/bench.mjs
cpu: AMD EPYC 7763 64-Core Processor
runtime: node v18.19.0 (x64-linux)

benchmark                   time (avg)             (min … max)       p75       p99      p995
-------------------------------------------------------------- -----------------------------
• movies.findMany() (all - 25000)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  318.23 ms/iter  (312.7 ms … 345.07 ms) 316.89 ms 345.07 ms 345.07 ms
Web Assembly: Latest    315.54 ms/iter (312.63 ms … 320.49 ms) 315.21 ms 320.49 ms 320.49 ms
Web Assembly: Current   318.51 ms/iter (313.45 ms … 336.04 ms)  317.5 ms 336.04 ms 336.04 ms
Node API: Current        236.6 ms/iter (227.85 ms … 242.21 ms) 240.87 ms 242.21 ms 242.21 ms

summary for movies.findMany() (all - 25000)
  Web Assembly: Current
   1.35x slower than Node API: Current
   1.01x slower than Web Assembly: Latest
   1x faster than Web Assembly: Baseline

• movies.findMany({ take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   12.76 ms/iter   (12.04 ms … 18.62 ms)  12.67 ms  18.62 ms  18.62 ms
Web Assembly: Latest     12.47 ms/iter   (12.13 ms … 17.57 ms)  12.33 ms  17.57 ms  17.57 ms
Web Assembly: Current    12.88 ms/iter    (12.1 ms … 15.49 ms)  12.93 ms  15.49 ms  15.49 ms
Node API: Current         9.45 ms/iter    (9.17 ms … 11.05 ms)   9.52 ms  11.05 ms  11.05 ms

summary for movies.findMany({ take: 2000 })
  Web Assembly: Current
   1.36x slower than Node API: Current
   1.03x slower than Web Assembly: Latest
   1.01x slower than Web Assembly: Baseline

• movies.findMany({ where: {...}, take: 2000 })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline    2.11 ms/iter     (1.85 ms … 3.72 ms)   2.03 ms   3.53 ms   3.53 ms
Web Assembly: Latest      2.08 ms/iter     (1.85 ms … 3.69 ms)   2.06 ms   3.49 ms   3.53 ms
Web Assembly: Current     2.11 ms/iter      (1.86 ms … 4.4 ms)   2.05 ms   3.49 ms   3.73 ms
Node API: Current         1.59 ms/iter     (1.47 ms … 2.59 ms)   1.58 ms    2.4 ms   2.44 ms

summary for movies.findMany({ where: {...}, take: 2000 })
  Web Assembly: Current
   1.32x slower than Node API: Current
   1.01x slower than Web Assembly: Latest
   1x faster than Web Assembly: Baseline

• movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline   12.47 ms/iter   (12.06 ms … 14.42 ms)  12.51 ms  14.42 ms  14.42 ms
Web Assembly: Latest     12.65 ms/iter   (12.24 ms … 16.64 ms)  12.75 ms  16.64 ms  16.64 ms
Web Assembly: Current    12.56 ms/iter   (12.05 ms … 19.63 ms)  12.59 ms  19.63 ms  19.63 ms
Node API: Current         9.69 ms/iter    (9.13 ms … 10.26 ms)  10.02 ms  10.26 ms  10.26 ms

summary for movies.findMany({ include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.3x slower than Node API: Current
   1.01x slower than Web Assembly: Baseline
   1.01x faster than Web Assembly: Latest

• movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline    1.93 ms/iter     (1.84 ms … 3.26 ms)   1.93 ms   2.52 ms   3.24 ms
Web Assembly: Latest      1.98 ms/iter     (1.84 ms … 4.83 ms)   1.94 ms   2.95 ms   3.17 ms
Web Assembly: Current        2 ms/iter     (1.86 ms … 3.21 ms)   1.95 ms   3.16 ms   3.21 ms
Node API: Current         1.68 ms/iter     (1.53 ms … 3.48 ms)   1.63 ms   2.45 ms   2.78 ms

summary for movies.findMany({ where: {...}, include: { cast: true } take: 2000 }) (m2m)
  Web Assembly: Current
   1.19x slower than Node API: Current
   1.03x slower than Web Assembly: Baseline
   1.01x slower than Web Assembly: Latest

• movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline    12.8 ms/iter   (12.23 ms … 15.71 ms)  12.93 ms  15.71 ms  15.71 ms
Web Assembly: Latest      12.6 ms/iter   (12.26 ms … 13.21 ms)  12.66 ms  13.21 ms  13.21 ms
Web Assembly: Current    12.79 ms/iter   (12.16 ms … 18.24 ms)  12.79 ms  18.24 ms  18.24 ms
Node API: Current        10.23 ms/iter    (9.56 ms … 14.42 ms)  10.41 ms  14.42 ms  14.42 ms

summary for movies.findMany({ take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.25x slower than Node API: Current
   1.02x slower than Web Assembly: Latest
   1x faster than Web Assembly: Baseline

• movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline    1.98 ms/iter     (1.85 ms … 5.08 ms)   1.96 ms   2.82 ms   2.94 ms
Web Assembly: Latest      1.96 ms/iter     (1.82 ms … 3.03 ms)   1.93 ms   2.93 ms   3.01 ms
Web Assembly: Current     1.97 ms/iter     (1.84 ms … 3.38 ms)   1.94 ms   3.04 ms   3.36 ms
Node API: Current         1.63 ms/iter     (1.52 ms … 2.13 ms)   1.64 ms   1.93 ms   2.01 ms

summary for movie.findMany({ where: { ... }, take: 2000, include: { cast: { include: { person: true } } } })
  Web Assembly: Current
   1.21x slower than Node API: Current
   1x faster than Web Assembly: Latest
   1.01x faster than Web Assembly: Baseline

• movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  925.12 µs/iter   (862.01 µs … 1.43 ms) 929.44 µs   1.31 ms   1.41 ms
Web Assembly: Latest    936.46 µs/iter    (859.3 µs … 1.56 ms) 926.85 µs   1.47 ms   1.53 ms
Web Assembly: Current   953.91 µs/iter    (871.5 µs … 1.68 ms) 942.31 µs   1.56 ms   1.58 ms
Node API: Current       852.15 µs/iter    (778.3 µs … 1.04 ms)  864.6 µs 949.89 µs 983.01 µs

summary for movie.findMany({ where: { reviews: { author: { ... } }, take: 100 }) (to-many -> to-one)
  Web Assembly: Current
   1.12x slower than Node API: Current
   1.03x slower than Web Assembly: Baseline
   1.02x slower than Web Assembly: Latest

• movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
-------------------------------------------------------------- -----------------------------
Web Assembly: Baseline  941.66 µs/iter   (865.02 µs … 1.47 ms) 934.73 µs   1.34 ms   1.42 ms
Web Assembly: Latest    951.11 µs/iter   (864.87 µs … 2.41 ms) 930.36 µs   1.48 ms   1.67 ms
Web Assembly: Current   927.79 µs/iter   (873.38 µs … 1.47 ms) 934.08 µs   1.27 ms    1.4 ms
Node API: Current       836.36 µs/iter    (775.9 µs … 1.07 ms) 859.97 µs  950.3 µs  987.5 µs

summary for movie.findMany({ where: { cast: { person: { ... } }, take: 100 }) (m2m -> to-one)
  Web Assembly: Current
   1.11x slower than Node API: Current
   1.01x faster than Web Assembly: Baseline
   1.03x faster than Web Assembly: Latest

After changes in d9e3510

@jkomyno jkomyno changed the base branch from main to fix/clippy January 2, 2024 18:06
Base automatically changed from fix/clippy to main January 3, 2024 12:44
Copy link
Contributor

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I guess the failing tests are unrelated?

@jkomyno
Copy link
Contributor Author

jkomyno commented Jan 3, 2024

Looks good, I guess the failing tests are unrelated?

There were clippy issues already fixed upstream, I've update the branch, let's see how the CI goes.
If it goes green, I'll merge it. Thanks for the review!

@jkomyno
Copy link
Contributor Author

jkomyno commented Jan 8, 2024

🚨 WASM query-engine: 1 benchmark(s) have regressed at least 2%

Full benchmark report
After changes in d9e3510

Info: both @SevInf and I agree that this benchmark can't really prevent us to upgrade to the newest Rust version.

@jkomyno jkomyno merged commit 16ee652 into main Jan 11, 2024
136 of 138 checks passed
@jkomyno jkomyno deleted the feat/nix-update-flake-for-rust-1.75.0 branch January 11, 2024 10:42
@Jolg42 Jolg42 modified the milestones: 5.8.0, 5.9.0 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants