chore: move itertools to workspace dependencies #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqrln
requested review from
ospfranco and
Druue
and removed request for
a team
WASM Size
|
CodSpeed Performance ReportMerging #4575 will not alter performanceComparing Summary
|
miguelff
approved these changes
Dec 15, 2023
|
If it doesn't cause harm I'd also update itertools to 0.12 as part of this PR. |
|
@miguelff done |
Move `itertools` to workspace dependencies to make it easier to manage its version. In principle we could also update it to `0.12` without introducing multiple major versions of the dependency: even though some of our dependencies transitively depend on `itertools = "0.10"`, as far as I can tell, only one is used at run time (`sqlformat`), and it is updatable to a newer version that requires `itertools = "0.12"`. `criterion`, `prost-derive` and `prost-build` all depend on older itertools even in their latest versions but that doesn't matter for the size of distributable binaries. I didn't do that in this PR, it can be done separately. Closes: prisma/team-orm#750
aqrln
force-pushed
the
chore-move-itertools-to-workspace-dependencies
branch
from
bf53159 to
0ef131a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
itertoolsto workspace dependencies to make it easier to manage its version and avoid multiple major versions.In principle we could also update it to
0.12without introducing multiple major versions of the dependency in our binaries: even though some of our dependencies transitively depend onitertools = "0.10", as far as I can tell, only one is used at run time (sqlformat), and it is updatable to a newer version that requiresitertools = "0.12".criterion,prost-deriveandprost-buildall depend on older itertools even in their latest versions but they don't matter for the size of distributable binaries.I didn't do that in this PR, it can be done either here or separately.UPD: done in this PR as per request below.Closes: https://github.com/prisma/team-orm/issues/750