Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Track wasm size over time #4568

Merged
merged 3 commits into from
Dec 14, 2023
Merged

ci: Track wasm size over time #4568

merged 3 commits into from
Dec 14, 2023

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Dec 14, 2023

Adds wasm and gzipped wasm engine size to the dashboard.

Fix prisma/team-orm#666

ci: Track wasm size over time
52dde0b 
Adds wasm and gzipped wasm engine size to the dashboard.

Fix prisma/team-orm#666
@SevInf SevInf requested a review from a team as a code owner December 14, 2023 12:02
@SevInf SevInf requested review from ospfranco and Druue and removed request for a team December 14, 2023 12:02
@SevInf SevInf added this to the 5.8.0 milestone Dec 14, 2023
@SevInf SevInf requested a review from aqrln December 14, 2023 12:02
SevInf
SevInf commented Dec 14, 2023
View reviewed changes
nix/all-engines.nix Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

WASM Size

Engine This PR Base branch Diff
WASM 3.184MiB 3.192MiB -8.132KiB
WASM (gzip) 1.199MiB 1.202MiB -3.434KiB

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 14, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #4568 will not alter performance

Comparing wasm-size-overtime (c674810) with main (974dce5)

Summary

✅ 11 untouched benchmarks

aqrln
aqrln approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! Feel free to ignore style nits about indentation, I'm thinking about adding nixpkgs-fmt as the formatter to the flake and formatting everything automatically anyway.

nix/all-engines.nix Outdated Show resolved Hide resolved
nix/all-engines.nix Outdated Show resolved Hide resolved
nix/all-engines.nix Outdated Show resolved Hide resolved
nix/all-engines.nix Show resolved Hide resolved
@aqrln
Apply suggestions from code review
c674810 
Co-authored-by: Alexey Orlenko <[email protected]>
@SevInf SevInf merged commit 320b8be into main Dec 14, 2023
63 of 64 checks passed
@SevInf SevInf deleted the wasm-size-overtime branch December 14, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqrln aqrln aqrln approved these changes

@ospfranco ospfranco Awaiting requested review from ospfranco ospfranco is a code owner automatically assigned from prisma/orm-rust

@Druue Druue Awaiting requested review from Druue Druue is a code owner automatically assigned from prisma/orm-rust

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SevInf @aqrln