Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle native types for joined queries #4546

Merged
merged 6 commits into from
Dec 18, 2023
Merged

fix: handle native types for joined queries #4546

merged 6 commits into from
Dec 18, 2023

Conversation

Weakky
Copy link
Contributor

@Weakky Weakky commented Dec 8, 2023 •
edited
Loading

Overview

fixes prisma/prisma#22293

Note: Money type is always casted as numeric to avoid having to parse string currencies which depend on locales and can take highly variable shapes. context: have a look at this table 🤒 https://stackoverflow.com/q/71908140

@Weakky Weakky requested a review from a team as a code owner December 8, 2023 11:07
@Weakky Weakky requested review from jkomyno and Druue and removed request for a team December 8, 2023 11:07
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 8, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #4546 will not alter performance

Comparing fix/json-native-type (975bc96) with main (91dff98)

Summary

✅ 11 untouched benchmarks

@Weakky Weakky force-pushed the fix/json-native-type branch from 44c2cbc to b6ce565 Compare December 8, 2023 14:22
@janpio janpio added this to the 5.8.0 milestone Dec 8, 2023
@Weakky Weakky force-pushed the fix/json-native-type branch from d6bda8e to a61155a Compare December 14, 2023 13:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2023 •
edited
Loading

WASM Size

Engine This PR Base branch Diff
WASM 3.183MiB 3.184MiB -1.192KiB
WASM (gzip) 1.198MiB 1.199MiB -963.000B

aqrln
aqrln reviewed Dec 18, 2023
View reviewed changes
psl/builtin-connectors/Cargo.toml Outdated Show resolved Hide resolved
quaint/src/visitor/postgres.rs Outdated Show resolved Hide resolved
@Weakky Weakky merged commit 2592cb6 into main Dec 18, 2023
66 of 74 checks passed
@Weakky Weakky deleted the fix/json-native-type branch December 18, 2023 12:21
Weakky added a commit that referenced this pull request Dec 18, 2023
@Weakky
fix: handle native types for joined queries (#4546)
0ca5ccb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semoal semoal semoal left review comments

@aqrln aqrln aqrln left review comments

@miguelff miguelff miguelff approved these changes

@jkomyno jkomyno Awaiting requested review from jkomyno jkomyno is a code owner automatically assigned from prisma/orm-rust

@Druue Druue Awaiting requested review from Druue Druue is a code owner automatically assigned from prisma/orm-rust

Assignees

@Weakky Weakky

Labels
None yet
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.

Inconsistent column data: Unexpected conversion failure from String to datetime. Reason: $trailing input
5 participants
@Weakky @miguelff @aqrln @semoal @janpio