psl: fix unit test failing on main #4523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`distinctOn` was renamed to `nativeDistinct` but something went wrong with joins PR merge so it reverted the old name in one of the tests.
aqrln
requested review from
miguelff and
jkomyno
and removed request for
a team
|
Thanks, we can probably close this in favor of the previous #4520 though |
|
duplicate of #4520 |
CodSpeed Performance ReportMerging #4523 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distinctOnwas renamed tonativeDistinctbut something went wrongwith joins PR merge so it reverted the old name in one of the tests.