feat(query-engine-common): reduce duplicated code between query-engine-node-api and query-engine-wasm

[jkomyno]

This PR closes https://github.com/prisma/team-orm/issues/692.

This PR is a follow-up of #4466.

/integration

[Weakky]

Thanks for taking care of that! Are there reasons why 👇🏻 cannot be part of query-engine-common too?

prisma-engines/query-engine/query-engine-node-api/src/engine.rs

Lines 35 to 78 in 9cb6834

	/// The state of the engine.
	enum Inner {
	/// Not connected, holding all data to form a connection.
	Builder(EngineBuilder),
	/// A connected engine, holding all data to disconnect and form a new
	/// connection. Allows querying when on this state.
	Connected(ConnectedEngine),
	}
	/// Everything needed to connect to the database and have the core running.
	struct EngineBuilder {
	schema: Arc<psl::ValidatedSchema>,
	config_dir: PathBuf,
	env: HashMap<String, String>,
	engine_protocol: EngineProtocol,
	}
	/// Internal structure for querying and reconnecting with the engine.
	struct ConnectedEngine {
	schema: Arc<psl::ValidatedSchema>,
	query_schema: Arc<QuerySchema>,
	executor: crate::Executor,
	config_dir: PathBuf,
	env: HashMap<String, String>,
	metrics: Option<MetricRegistry>,
	engine_protocol: EngineProtocol,
	}
	/// Returned from the `serverInfo` method in javascript.
	#[derive(Debug, Serialize)]
	#[serde(rename_all = "camelCase")]
	struct ServerInfo {
	commit: String,
	version: String,
	primary_connector: Option<String>,
	}
	#[derive(Debug, Deserialize)]
	#[serde(rename_all = "camelCase")]
	struct MetricOptions {
	format: MetricFormat,
	#[serde(default)]
	global_labels: HashMap<String, String>,
	}

[medz]

Thumbs up! I've been waiting for it for a year! Finally, third-party clients no longer have to copy Prisma engines code! Engine upgrades will not bring devastating damage to third-party clients!

[medz]

Could more be done? For example, it is the same as described in #3757, because a large amount of logic code is common between wasm engine and napi engine.

[jkomyno]

Thanks for taking care of that! Are there reasons why 👇🏻 cannot be part of query-engine-common too?

prisma-engines/query-engine/query-engine-node-api/src/engine.rs

Lines 35 to 78 in 9cb6834

	/// The state of the engine.
	enum Inner {
	/// Not connected, holding all data to form a connection.
	Builder(EngineBuilder),
	/// A connected engine, holding all data to disconnect and form a new
	/// connection. Allows querying when on this state.
	Connected(ConnectedEngine),
	}
	/// Everything needed to connect to the database and have the core running.
	struct EngineBuilder {
	schema: Arc<psl::ValidatedSchema>,
	config_dir: PathBuf,
	env: HashMap<String, String>,
	engine_protocol: EngineProtocol,
	}
	/// Internal structure for querying and reconnecting with the engine.
	struct ConnectedEngine {
	schema: Arc<psl::ValidatedSchema>,
	query_schema: Arc<QuerySchema>,
	executor: crate::Executor,
	config_dir: PathBuf,
	env: HashMap<String, String>,
	metrics: Option<MetricRegistry>,
	engine_protocol: EngineProtocol,
	}
	/// Returned from the `serverInfo` method in javascript.
	#[derive(Debug, Serialize)]
	#[serde(rename_all = "camelCase")]
	struct ServerInfo {
	commit: String,
	version: String,
	primary_connector: Option<String>,
	}
	#[derive(Debug, Deserialize)]
	#[serde(rename_all = "camelCase")]
	struct MetricOptions {
	format: MetricFormat,
	#[serde(default)]
	global_labels: HashMap<String, String>,
	}

Good question! There is no good reason to exclude that, besides that it'd need some additional conditional checks.
I've implemented your suggestion in 1af7189, let me know what you think ☺️

[jkomyno]

Oh, and ServerInfo is also shared between query-engine-node-api and query-engine-wasm, but that's probably safe to remove (I'll continue #4524 for "tech debt Friday").

[github-actions]

WASM Size

Engine	This PR	Base branch	Diff
WASM	3.185MiB	3.184MiB	1.187KiB
WASM (gzip)	1.200MiB	1.199MiB	741.000B