-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver-adapters: convert Decimals to Strings when calling JS #4408
Conversation
When forwarding the input to the driver adapter, we used to convert
decimal values to f64. On a large numbers, that lost some precision.
Changing this to convert them to strings instead.
Fix prisma/team-orm#497
TODO: after this gets to the client, unskip `decimal/presion` test
there.
7c2d6bf
to
246e0ce
Compare
CodSpeed Performance ReportMerging #4408 will not alter performanceComparing Summary
|
Trying this PR locally, I verified that |
Libsql is now fixed (to the extend it works on main, so 2 failed test) |
When forwarding the input to the driver adapter, we used to convert
decimal values to f64. On a large numbers, that lost some precision.
Changing this to convert them to strings instead.
Fix prisma/team-orm#497
TODO: after this gets to the client, unskip
decimal/presion
testthere.