Skip to content

Commit

Permalink
Add todo comment
Browse files Browse the repository at this point in the history
  • Loading branch information
aqrln committed Feb 16, 2024
1 parent 5bfb5b9 commit 2ee01a2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions query-engine/query-structure/src/query_arguments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ impl QueryArguments {
has_distinct_feature && self.connector_supports_distinct_on() && self.order_by.is_empty()
}

// TODO: separation between `can_distinct_in_db` and `can_distinct_in_db_with_joins` shouldn't
// be necessary once nativeDistinct is GA.
pub fn can_distinct_in_db_with_joins(&self) -> bool {
self.connector_supports_distinct_on()
&& native_distinct_compatible_with_order_by(self.distinct.as_ref(), &self.order_by)
Expand Down

0 comments on commit 2ee01a2

Please sign in to comment.